From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0FFC43381 for ; Tue, 19 Feb 2019 05:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 283F4217D7 for ; Tue, 19 Feb 2019 05:27:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="stQaIQnA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726067AbfBSF1K (ORCPT ); Tue, 19 Feb 2019 00:27:10 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35191 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfBSF1J (ORCPT ); Tue, 19 Feb 2019 00:27:09 -0500 Received: by mail-pg1-f196.google.com with SMTP id s198so9542361pgs.2 for ; Mon, 18 Feb 2019 21:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RKppS4N/pucLneU7u7OuQASg2CpO6oS44Q4JTfsMPAw=; b=stQaIQnAXPP7kP0rX1NWX4IpwQvl83CQk58hebS+vVVENZDexzqtz3/cIRuTYQN7gq TALZIEz5aBt9YMsv8UBBpKqgjn9BLIoij9DrXRLHrmAVaEkC9d7e3EWZwCOfeh5awMEr ZvQRS1vLusDlVPAs2hhuqjkG3cvBpgtb1oqt2s+xvhjQliEbOBEtp/QNH6uxbdlBHZ0S cMgf2VQSKUIB4VoPtDnEywQV7u0Re3L9aBLx51UIcaeM4VFMo8WN/DAtAXaM/nqM+HrQ j8noqaVkYnMwfSbv/nPYCPzZyON6a29fvPXgrPnOqtvUlu34VPpxHZL6XuXDn5zr74gC Ew2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RKppS4N/pucLneU7u7OuQASg2CpO6oS44Q4JTfsMPAw=; b=MMQa3jt5sUEAstyw/9q9RyGHIacGWBYROPL+G6Qo5KEx1vOUblDRGvGbB1E9vi6Vhn UR41DTjy+Gf8IBKK1DtewSFgSbUIjDKKR4G6yc313nRNZ2W/0RnpgeFqhH9tTar9m4j6 wqg0k3ksq2Y0j5r0zlJDGsAsNZOXjc+AM8NbVMzIW2PR6ur+7PGVYsTKE/Rm10rxxfHc Mgq/uAqW5GRI+bMifQJGu5+ujybpn3rHRu4kWlwGZ52pBY3Um2M2eSvMGsv7TXj+bB5A nT2jeV91davC4U6IUSkT8CAUOPjvnsliRY5xiy43Nfg4ecmpX3Z6mzFCnpnf22n7ilM/ AUZA== X-Gm-Message-State: AHQUAuYDLKabqLU4gCrnGbRH7IhA1jzg0mOk6/PwdEQx6/kPMhoQGDIY SUzRVweHvF86wF68HsCHmkhOCxqCYqAF5eBc8j2rnQ== X-Google-Smtp-Source: AHgI3Ibuftbp7pYQ9qPltAYTia+TRkav59L+rjqh5AOTwGiX50H4CqM4K93FixiD20CeZK+QEUKAYk5Db6R0xiGi288= X-Received: by 2002:a62:b2c3:: with SMTP id z64mr27710818pfl.149.1550554029088; Mon, 18 Feb 2019 21:27:09 -0800 (PST) MIME-Version: 1.0 References: <20190211085548.7190-1-vladbu@mellanox.com> <20190211085548.7190-8-vladbu@mellanox.com> <20190214182442.GA19269@splinter> <20190215113041.GA10511@splinter> In-Reply-To: From: Cong Wang Date: Mon, 18 Feb 2019 21:26:57 -0800 Message-ID: Subject: Re: [PATCH net-next v4 07/17] net: sched: protect filter_chain list with filter_chain_lock mutex To: Vlad Buslov Cc: Ido Schimmel , "netdev@vger.kernel.org" , "jhs@mojatatu.com" , "jiri@resnulli.us" , "davem@davemloft.net" , "ast@kernel.org" , "daniel@iogearbox.net" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 7:35 AM Vlad Buslov wrote: > > Another problem that I found in cls_fw and cls_route is that they set > arg->stop when empty. Both of them have code unchanged since it was > committed initially in 2005 so I assume this convention is no longer > relevant because all other classifiers don't do that (they only set > arg->stop when arg->fn returns negative value). > The question is why do you want to use arg->stop==0 as an indication for emptiness? Isn't what arg->count==0 supposed to be?