From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A993C169C4 for ; Tue, 29 Jan 2019 05:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB2502177E for ; Tue, 29 Jan 2019 05:25:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pi7eSTy3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725790AbfA2FY7 (ORCPT ); Tue, 29 Jan 2019 00:24:59 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34847 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfA2FY7 (ORCPT ); Tue, 29 Jan 2019 00:24:59 -0500 Received: by mail-pg1-f195.google.com with SMTP id s198so8274782pgs.2; Mon, 28 Jan 2019 21:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f1hL6VhkYXZ0rs8/PUnOaVQDDZWQnFwdLRRLkQ8pfy0=; b=Pi7eSTy3aji40uXdiRkKqXiCpuczJwbID2+TsMkFduCcbo7XKjFxa52ytX+GMh3tZu psfQ0uHvPxvlYKVc1iz7tx5M7zHs1t9QoqZl3jIRHCzTuUCsX19uMgW0Sq7WkuWTmUgg bu65giHliL2fiTAYn5xLfY0MmjKzTe1JZjDh8+gdVB6XBylW2eGnXapLPUzeYMbzTxlp pASl1y6dFkKqileUQwUO+8XmLISAnimxvHv69wgzJFPnHXe25X0hBKfPuP0NF4bRYXH8 HrhcGjSpWJewhFVyPQyIB6xbseE9bMVfPPJwYPk0p1c1xyVsVsZvHs73lWf5fHMl1wP8 nj/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f1hL6VhkYXZ0rs8/PUnOaVQDDZWQnFwdLRRLkQ8pfy0=; b=Dnt43DGFLsQaEjZ8GkMcofAiAeGFIHZM5M7IoQ7dVKYc5DJ5tGG9yPoRK9VHDsB7Zy OQVLgNPridEiC/namWhMD6v4Cl3e9T6s0PXv2GrWn4G9+9s96QtyTi6vX4DtxCxJXNQF 5YnTjBwfi4PrzcB2i2H9vE56IUkVTOpD3vfKcU7WCw7fr5bWHNrOB2rt72KFcJbRaVfS bXOz0cXsRnUG9Qtu/nK20S3G8KA+gU7T0MOns+NdUE97pLoIZOaX4+3l1toZP7AbUVJz kS2j6wYKjhIy8mgl+dar5ISk2bdCxrEVm8wPFL1wjecs/tiuzfnHfdj68OV0rLnHZVCn vG9w== X-Gm-Message-State: AJcUukfqtOr7rl3hTtepAK+1ispd6BetZ4Q3jZV9nObsDvPTvSCbrd32 9LPS76KD9AQCA1dfhl5mSN/eFY/jxeC3+JRiuJrwYI5B X-Google-Smtp-Source: ALg8bN53/40XEygsDaisetBDWLOVxG6tNKYEKK9PfKnbN3Z2Z0AETnnRfnyMKuEsAZAi8KoA+lYZhEm9pD5rwRedwf4= X-Received: by 2002:a62:62c5:: with SMTP id w188mr24940621pfb.160.1548739498661; Mon, 28 Jan 2019 21:24:58 -0800 (PST) MIME-Version: 1.0 References: <20190128235750.18412-1-pablo@netfilter.org> <20190128235750.18412-7-pablo@netfilter.org> In-Reply-To: <20190128235750.18412-7-pablo@netfilter.org> From: Cong Wang Date: Mon, 28 Jan 2019 21:24:46 -0800 Message-ID: Subject: Re: [PATCH 06/33] netfilter: nf_tables: Support RULE_ID reference in new rule To: Pablo Neira Ayuso Cc: NetFilter , David Miller , Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 28, 2019 at 4:00 PM Pablo Neira Ayuso wrote: > > From: Phil Sutter > > To allow for a batch to contain rules in arbitrary ordering, introduce > NFTA_RULE_POSITION_ID attribute which works just like NFTA_RULE_POSITION > but contains the ID of another rule within the same batch. This helps > iptables-nft-restore handling dumps with mixed insert/append commands > correctly. > > Note that NFTA_RULE_POSITION takes precedence over > NFTA_RULE_POSITION_ID, so if the former is present, the latter is > ignored. It looks like you forgot to add NFTA_RULE_POSITION_ID into nft_rule_policy[]?