From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A370C43381 for ; Mon, 18 Feb 2019 19:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25C13217D9 for ; Mon, 18 Feb 2019 19:53:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xv/yo592" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbfBRTxv (ORCPT ); Mon, 18 Feb 2019 14:53:51 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42059 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfBRTxv (ORCPT ); Mon, 18 Feb 2019 14:53:51 -0500 Received: by mail-pf1-f195.google.com with SMTP id n74so9070365pfi.9 for ; Mon, 18 Feb 2019 11:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WP0xMNWvG1uDWvpCIa8tOKJS2jfXVn1JA6rgEj9Yt88=; b=Xv/yo592Etp4AwL7kW9BewwFRrpavoFguSYxAJzrKjTEotrxTle72mQtqaqBMm/twz +arfKnM9wT+rkb3YaxLJ8QqNMRnHrnw0X4dxZsshu/hp+kn5ku+duUCuGJP75IRiFM9Z Y4pjYSnHS8j/UOuO2yagRcXxUQtmBcY/WvymslaJqGvk05ZmzfrjoPzexmDluqr6JfRI +YAn/C2BCUYjcR+7sR8YcUdJifyqniCD6QvTBfMkWOIIAlIFCIRTWcUJPNK9UihvYUC6 xAEtdZayUHLi4pHSK+FrY1GW5L76iBLmzbITmhkvmTdAJrSkci53YAO7Ll4qyf8h5ZPG 5Pkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WP0xMNWvG1uDWvpCIa8tOKJS2jfXVn1JA6rgEj9Yt88=; b=oJLS9Qcp8ctwu6+BPPKNYYkTsrf/ukXHs1TLmMMu1do+C2lTOs8VWZmoMVeIOv/UxY jJd0mkfduteuwRQo3rNEmbqOgmKz037nfa7oeqJM9aIeEd/+sjVHLdk6h+B6qR/X4mux cBq3X1mkHbsZNX3giJDym9u7ARdwgsere1rUEvxR97PRFrJJ4tdr5Q0lG84JT7f/GPZ9 mITXBKBlVOqryvntcRejWVl8yV3YClJDAD6acRSlCGVvDJBrws9WXxk1ynjQ7nTfD5hV UvoXRZXtAY98hYn3tlWr+9SypDSt/mhoNfuS1BqeGfcXbvyqlB4DIHDx6jSwi1kPe9X4 gTAw== X-Gm-Message-State: AHQUAuaYMJfcumFbpnvyjx1d0UODrGGmFONU6i/ENbCO1D+VNM3lTLP+ aSS6+PyfxEG18W71mVYHhvHoatXtz638YWRbcHU= X-Google-Smtp-Source: AHgI3IZvwOuIH+KFRXMCt2pSqtTfXfYcJ6/7HrgYsWjufbnaxy5tewupURX4ilFloe+XGogO0MrW/dJHi3TMmQ/7wK0= X-Received: by 2002:a63:28c1:: with SMTP id o184mr6202300pgo.123.1550519630401; Mon, 18 Feb 2019 11:53:50 -0800 (PST) MIME-Version: 1.0 References: <20190211085548.7190-1-vladbu@mellanox.com> <20190211085548.7190-11-vladbu@mellanox.com> In-Reply-To: <20190211085548.7190-11-vladbu@mellanox.com> From: Cong Wang Date: Mon, 18 Feb 2019 11:53:39 -0800 Message-ID: Subject: Re: [PATCH net-next v4 10/17] net: sched: refactor tp insert/delete for concurrent execution To: Vlad Buslov Cc: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , David Miller , Alexei Starovoitov , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 11, 2019 at 12:56 AM Vlad Buslov wrote: > +#define tcf_proto_dereference(p, tp) \ > + rcu_dereference_protected(p, lockdep_tcf_proto_is_locked(tp)) > + BTW, it is not used anywhere even on top of your cls_flower changes... $ git grep tcf_proto_dereference include/net/sch_generic.h:#define tcf_proto_dereference(p, tp) \ Please don't introduce new things unitl you actually use it.