netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: sched: fix use before alloc of per cpu stats
Date: Mon, 15 Jan 2018 22:43:25 -0800	[thread overview]
Message-ID: <CAM_iQpXMd91wyv5hiV7J0XeKR-8gWZ5dc7GVka7PmifdtgWePQ@mail.gmail.com> (raw)
In-Reply-To: <b7e58a49-744b-b34a-9fbe-a58700ddd20a@lab.ntt.co.jp>

On Mon, Jan 15, 2018 at 10:33 PM, Prashant Bhole
<bhole_prashant_q7@lab.ntt.co.jp> wrote:
> Pardon my ignorance, I think it is necessary to forward d59f5ffa59d8 to
> -net. Because previously flags were set during init and checked after init
> to allocate memory. static_flags makes the flags available before init,
> hence we can allocate memory before init.

Oh, right, but we can allocate it unconditionally and free it if not needed
after ->init(). It is not prettier though. ;)

> Sorry, but from your reply I couldn't understand whether we need v2 for
> net-next.
>

I don't think you need to send v2, because the one for -net will be merged
(with a conflict) into -net-next by DaveM.

      reply	other threads:[~2018-01-16  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15  5:52 [PATCH net-next] net: sched: fix use before alloc of per cpu stats Prashant Bhole
2018-01-16  5:08 ` Cong Wang
2018-01-16  5:47   ` Prashant Bhole
2018-01-16  5:57     ` Cong Wang
2018-01-16  6:33       ` Prashant Bhole
2018-01-16  6:43         ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpXMd91wyv5hiV7J0XeKR-8gWZ5dc7GVka7PmifdtgWePQ@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).