From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH net-next] net: sched: fix use before alloc of per cpu stats Date: Mon, 15 Jan 2018 22:43:25 -0800 Message-ID: References: <20180115055222.4248-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "David S . Miller" , Jamal Hadi Salim , Jiri Pirko , Daniel Borkmann , Linux Kernel Network Developers To: Prashant Bhole Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:42087 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbeAPGnq (ORCPT ); Tue, 16 Jan 2018 01:43:46 -0500 Received: by mail-pf0-f194.google.com with SMTP id b25so2881944pfd.9 for ; Mon, 15 Jan 2018 22:43:45 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 15, 2018 at 10:33 PM, Prashant Bhole wrote: > Pardon my ignorance, I think it is necessary to forward d59f5ffa59d8 to > -net. Because previously flags were set during init and checked after init > to allocate memory. static_flags makes the flags available before init, > hence we can allocate memory before init. Oh, right, but we can allocate it unconditionally and free it if not needed after ->init(). It is not prettier though. ;) > Sorry, but from your reply I couldn't understand whether we need v2 for > net-next. > I don't think you need to send v2, because the one for -net will be merged (with a conflict) into -net-next by DaveM.