From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()
Date: Wed, 21 Nov 2018 10:17:06 -0800
Message-ID: <CAM_iQpXO1Etf0489ssLoGGg9bgtZWuYSYb25Si913aOi5pgsBQ@mail.gmail.com>
References: <20181121021309.6595-1-xiyou.wangcong@gmail.com>
 <20181121021309.6595-2-xiyou.wangcong@gmail.com> <a1e1b48b-68af-16f6-2442-b96718f6ae00@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Dumazet <edumazet@google.com>,
        David Miller <davem@davemloft.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f194.google.com ([209.85.214.194]:44191 "EHLO
        mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729656AbeKVEwn (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Nov 2018 23:52:43 -0500
Received: by mail-pl1-f194.google.com with SMTP id s5-v6so6614465plq.11
        for <netdev@vger.kernel.org>; Wed, 21 Nov 2018 10:17:18 -0800 (PST)
In-Reply-To: <a1e1b48b-68af-16f6-2442-b96718f6ae00@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 11/20/2018 06:13 PM, Cong Wang wrote:
> > Currently, we only dump a few selected skb fields in
> > netdev_rx_csum_fault(). It is not suffient for debugging checksum
> > fault. This patch introduces skb_dump() which dumps skb mac header,
> > network header and its whole skb->data too.
> >
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: David Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> > ---
>
>
> > +     print_hex_dump(level, "skb data: ", DUMP_PREFIX_OFFSET, 16, 1,
> > +                    skb->data, skb->len, false);
>
> As I mentioned to David, we want all the bytes that were maybe already pulled
>
> (skb->head starting point, not skb->data)

Hmm, with mac header and network header, it is effectively from skb->head, no?
Is there anything between skb->head and mac header?


>
> Also we will miss the trimmed bytes if there were padding data.
> And it seems the various bugs we have are all tied to the pulled or trimmed bytes.
>

Unless I miss something, the tailing padding data should be in range
[iphdr->tot_len, skb->len]. No?


Thanks