From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexander Duyck <aduyck@mirantis.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Alexander Duyck <alexander.duyck@gmail.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [net-next PATCH] udp: Resolve NULL pointer dereference
Date: Wed, 11 May 2016 21:29:34 -0700 [thread overview]
Message-ID: <CAM_iQpXWWbAKdkngMpE81Snmcam5cFY5JWt-tXSrHQVRU_nggA@mail.gmail.com> (raw)
In-Reply-To: <20160512022306.3691.40769.stgit@localhost.localdomain>
On Wed, May 11, 2016 at 7:24 PM, Alexander Duyck <aduyck@mirantis.com> wrote:
> While testing an OpenStack configuration using VXLANs I saw the following
> call trace:
...
>
> I believe the trace is pointing to the call to dev_net(dev) in
> udp4_lib_lookup_skb. If I am not mistaken I believe it is possible for us
> to have skb_dst(skb)->dev be NULL. So to resolve that I am adding a check
> for this case and skipping the assignment if such an event occurs.
Isn't in this tunneling case skb_dst() should be NULL?
next prev parent reply other threads:[~2016-05-12 4:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 2:24 [net-next PATCH] udp: Resolve NULL pointer dereference Alexander Duyck
2016-05-12 3:43 ` Eric Dumazet
2016-05-12 16:51 ` Alexander Duyck
2016-05-12 4:29 ` Cong Wang [this message]
2016-05-12 19:51 ` [net-next PATCH v2] udp: Resolve NULL pointer dereference over flow-based vxlan device Alexander Duyck
2016-05-12 19:55 ` Eric Dumazet
2016-05-12 20:27 ` Alexander Duyck
2016-05-12 20:55 ` Eric Dumazet
2016-05-12 20:02 ` Cong Wang
2016-05-12 20:15 ` Alexander Duyck
2016-05-12 23:23 ` [net-next PATCH v3] " Alexander Duyck
2016-05-13 4:43 ` Eric Dumazet
2016-05-13 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXWWbAKdkngMpE81Snmcam5cFY5JWt-tXSrHQVRU_nggA@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).