From: Cong Wang <xiyou.wangcong@gmail.com>
To: Linux Kernel Network Developers <netdev@vger.kernel.org>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [Patch net] net_sched: fix memory leaks when rmmod tc action modules
Date: Sat, 20 Feb 2016 16:27:07 -0800 [thread overview]
Message-ID: <CAM_iQpXb6ngsdRDo3QpzTis22rdhPwBkv33BPG9WyBffdbTC5A@mail.gmail.com> (raw)
In-Reply-To: <1455926779-9379-1-git-send-email-xiyou.wangcong@gmail.com>
On Fri, Feb 19, 2016 at 4:06 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> We only release the memory of the hashtable itself, not its
> entries inside. We need to do both.
>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Hmm, after a second thought, actually each action should take
a reference to its module, therefore module will not be removed
until all the actions are gone, so no leak here.
The reason why I saw a leak is tcf_hashinfo_destroy() is called
in netns cleanup in the other patch.
So, this patch should be targeted for net-next only. I will resend it
with an updated changelog with the other patch.
Sorry for the confusion.
prev parent reply other threads:[~2016-02-21 0:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 0:06 [Patch net] net_sched: fix memory leaks when rmmod tc action modules Cong Wang
2016-02-21 0:27 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXb6ngsdRDo3QpzTis22rdhPwBkv33BPG9WyBffdbTC5A@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).