From: Colin Cross <ccross@android.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Layton <jlayton@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Mandeep Singh Baines <msb@chromium.org>,
Paul Walmsley <paul@pwsan.com>, Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-nfs <linux-nfs@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Ben Chan <benchan@chromium.org>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 1/2] freezer: add unsafe versions of freezable helpers
Date: Mon, 6 May 2013 15:11:02 -0700 [thread overview]
Message-ID: <CAMbhsRRiWGrvqTKX_wcQM9v-k9nRuash54uHjXPY+HO4z4K6Dg@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFwbXk_r-4p37YiMTQj2HNRA94xohr6DADuQXpHsKSA7NQ@mail.gmail.com>
On Mon, May 6, 2013 at 2:58 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Mon, May 6, 2013 at 2:54 PM, Colin Cross <ccross@android.com> wrote:
>>>
>>> There are many other possibilities for other codepaths that end up in
>>> wait_for_response(). Once we get a solution in place for NFS, we'll
>>> need to do something very similar for CIFS.
>>
>> Makes sense, I will add CIFS to the patch. Would you prefer it in the
>> same or separate patches.
>
> Quite frankly, is it worth resurrecting these patches at all?
>
> The only things it actually complained about are not worth the pain
> fixing and are getting explicitly not warned about - is there any
> reason to believe the patches are worth maintaining and the extra
> complexity is worth it?
There was at least one real other case caught when this patch was
applied: https://lkml.org/lkml/2013/3/4/390. Tejun asked that I
resurrect it because I'm adding some additional APIs similar to
freezable_schedule() and he wanted to make sure they didn't get used
improperly in the future.
next prev parent reply other threads:[~2013-05-06 22:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 21:04 [PATCH 1/2] freezer: add unsafe versions of freezable helpers Colin Cross
2013-05-03 21:04 ` [PATCH 2/2] lockdep: check that no locks held at freeze time Colin Cross
[not found] ` <1367615050-3894-2-git-send-email-ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2013-05-04 13:04 ` Pavel Machek
2013-05-04 20:27 ` Colin Cross
2013-05-04 22:57 ` Pavel Machek
[not found] ` <20130504225715.GB24276-tWAi6jLit6GreWDznjuHag@public.gmane.org>
2013-05-04 23:49 ` Colin Cross
2013-05-05 0:05 ` Pavel Machek
[not found] ` <20130505000528.GA25454-tWAi6jLit6GreWDznjuHag@public.gmane.org>
2013-05-05 0:23 ` Colin Cross
[not found] ` <CAMbhsRQso4fW_DVL6U3zfbX3YbLsTy8-rUA-fo61Aw93bU+sQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-05 1:13 ` Pavel Machek
2013-05-05 9:18 ` Ingo Molnar
[not found] ` <20130505091844.GC22239-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-06 8:55 ` Peter Zijlstra
2013-05-06 12:11 ` Pavel Machek
2013-05-06 14:33 ` Linus Torvalds
2013-05-06 14:42 ` Peter Zijlstra
2013-05-06 19:01 ` Tejun Heo
2013-05-06 19:30 ` Colin Cross
2013-05-06 19:33 ` Tejun Heo
2013-05-06 20:06 ` Rafael J. Wysocki
2013-05-04 13:00 ` [PATCH 1/2] freezer: add unsafe versions of freezable helpers Pavel Machek
2013-05-04 20:23 ` Colin Cross
[not found] ` <CAMbhsRS6+hjTmrihVzgu3Dtyp8XAhJJ4VKMj=28G6xH3H73=6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-04 22:55 ` Pavel Machek
2013-05-05 9:23 ` Ingo Molnar
[not found] ` <20130505092318.GD22239-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-05 22:12 ` Pavel Machek
2013-05-06 10:56 ` Jeff Layton
2013-05-06 19:57 ` Colin Cross
[not found] ` <CAMbhsRQsFT2j_CuPL45J03itymcp3PNP8ckt3fAAo+hzavNrbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-06 21:43 ` Jeff Layton
[not found] ` <20130506174336.447d0d75-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-05-06 21:54 ` Colin Cross
2013-05-06 21:58 ` Linus Torvalds
2013-05-06 22:05 ` Jeff Layton
2013-05-06 22:11 ` Colin Cross [this message]
2013-05-06 22:14 ` Tejun Heo
2013-05-06 21:59 ` Jeff Layton
[not found] ` <1367615050-3894-1-git-send-email-ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2013-05-06 8:50 ` Peter Zijlstra
2013-05-06 10:58 ` Jeff Layton
2013-05-06 18:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMbhsRRiWGrvqTKX_wcQM9v-k9nRuash54uHjXPY+HO4z4K6Dg@mail.gmail.com \
--to=ccross@android.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=benchan@chromium.org \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jlayton@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msb@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paul@pwsan.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=smfrench@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).