netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking
@ 2015-08-13 22:01 Stuart Yoder
  2015-08-14  8:04 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Stuart Yoder @ 2015-08-13 22:01 UTC (permalink / raw)
  To: davem; +Cc: netdev, linux-kernel, scottwood, Stuart Yoder

make the list of Kconfig dependencies for Freescale
networking more general. Simplify to supported
architectures: ARM, ARM64, PPC, M68K

Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
 drivers/net/ethernet/freescale/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index ff76d4e..70782d7 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -5,9 +5,7 @@
 config NET_VENDOR_FREESCALE
 	bool "Freescale devices"
 	default y
-	depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
-		   M523x || M527x || M5272 || M528x || M520x || M532x || \
-		   ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM)
+	depends on M68K || PPC || ARM || ARM64
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
-- 
2.3.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking
  2015-08-13 22:01 [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking Stuart Yoder
@ 2015-08-14  8:04 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-08-14  8:04 UTC (permalink / raw)
  To: Stuart Yoder
  Cc: David S. Miller, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Scott Wood

On Fri, Aug 14, 2015 at 12:01 AM, Stuart Yoder
<stuart.yoder@freescale.com> wrote:
> make the list of Kconfig dependencies for Freescale
> networking more general. Simplify to supported
> architectures: ARM, ARM64, PPC, M68K
>
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ff76d4e..70782d7 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -5,9 +5,7 @@
>  config NET_VENDOR_FREESCALE
>         bool "Freescale devices"
>         default y
> -       depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
> -                  M523x || M527x || M5272 || M528x || M520x || M532x || \
> -                  ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM)
> +       depends on M68K || PPC || ARM || ARM64
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y.

This breaks m68k/allmodconfig:

drivers/net/ethernet/freescale/gianfar.c: In function ‘gfar_parse_group’:
drivers/net/ethernet/freescale/gianfar.c:684: error: ‘NO_IRQ’
undeclared (first use in this function)
drivers/net/ethernet/freescale/gianfar.c:684: error: (Each undeclared
identifier is reported only once
drivers/net/ethernet/freescale/gianfar.c:684: error: for each function
it appears in.)

P.S. Hint: Would have been caught earlier if the NET_VENDOR_* symbol
     had "|| COMPILE_TEST" among its dependencies.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-14  8:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 22:01 [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking Stuart Yoder
2015-08-14  8:04 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).