From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/net/ethernet/apple
Date: Thu, 27 Oct 2011 07:16:54 +0200 [thread overview]
Message-ID: <CAMuHMdUW5PjPU7qNOPA16CbxHJs-bL4r+aFcEGV95SDRBotXRg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdXxqKoPNNo9a+VK-Yzu0Qp-8zY2+OhHL6pDPF=dsnNK5Q@mail.gmail.com>
Hi Jeff,
On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal Semiconductor
> (Now Cirrus Logic) CS89[02]0, so it belongs in drivers/net/ethernet/cirrus,
> next to cs89x0.c.
And on the first -next run since its inclusion:
| drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
such file or directory
it needs the (shared) header file which is in drivers/net/ethernet/cirrus/.
http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/
> And according to drivers/net/ethernet/apple/mace.h, "mace" is the
> "Am79C940 MACE (Medium Access Control for Ethernet)", so mace and
> macmace should be in drivers/net/ethernet/amd/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2011-10-27 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:19 drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 5:16 ` Geert Uytterhoeven [this message]
2011-10-27 7:45 ` drivers/net/ethernet/apple Jeff Kirsher
2011-10-27 8:40 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:46 ` drivers/net/ethernet/apple Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUW5PjPU7qNOPA16CbxHJs-bL4r+aFcEGV95SDRBotXRg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=benh@kernel.crashing.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).