* drivers/net/ethernet/apple
@ 2011-10-25 20:19 Geert Uytterhoeven
2011-10-27 5:16 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:46 ` drivers/net/ethernet/apple Benjamin Herrenschmidt
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2011-10-25 20:19 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: Benjamin Herrenschmidt, netdev, linux-kernel
Hi Jeff,
drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal Semiconductor
(Now Cirrus Logic) CS89[02]0, so it belongs in drivers/net/ethernet/cirrus,
next to cs89x0.c.
And according to drivers/net/ethernet/apple/mace.h, "mace" is the
"Am79C940 MACE (Medium Access Control for Ethernet)", so mace and
macmace should be in drivers/net/ethernet/amd/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/net/ethernet/apple
2011-10-25 20:19 drivers/net/ethernet/apple Geert Uytterhoeven
@ 2011-10-27 5:16 ` Geert Uytterhoeven
2011-10-27 7:45 ` drivers/net/ethernet/apple Jeff Kirsher
2011-10-27 7:46 ` drivers/net/ethernet/apple Benjamin Herrenschmidt
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2011-10-27 5:16 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: Benjamin Herrenschmidt, netdev, linux-kernel
Hi Jeff,
On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal Semiconductor
> (Now Cirrus Logic) CS89[02]0, so it belongs in drivers/net/ethernet/cirrus,
> next to cs89x0.c.
And on the first -next run since its inclusion:
| drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
such file or directory
it needs the (shared) header file which is in drivers/net/ethernet/cirrus/.
http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/
> And according to drivers/net/ethernet/apple/mace.h, "mace" is the
> "Am79C940 MACE (Medium Access Control for Ethernet)", so mace and
> macmace should be in drivers/net/ethernet/amd/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/net/ethernet/apple
2011-10-27 5:16 ` drivers/net/ethernet/apple Geert Uytterhoeven
@ 2011-10-27 7:45 ` Jeff Kirsher
2011-10-27 8:40 ` drivers/net/ethernet/apple Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Kirsher @ 2011-10-27 7:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Benjamin Herrenschmidt, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:
> Hi Jeff,
>
> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal
> Semiconductor
> > (Now Cirrus Logic) CS89[02]0, so it belongs in
> drivers/net/ethernet/cirrus,
> > next to cs89x0.c.
>
> And on the first -next run since its inclusion:
>
> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
> such file or directory
>
> it needs the (shared) header file which is in
> drivers/net/ethernet/cirrus/.
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/
Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
drivers/net/ethernet/apple/ because it was grouped with the "common"
drivers. The intent was to group drivers that use common code together.
I can put together a patch to fix this if you are not able to.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/net/ethernet/apple
2011-10-25 20:19 drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 5:16 ` drivers/net/ethernet/apple Geert Uytterhoeven
@ 2011-10-27 7:46 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2011-10-27 7:46 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Jeff Kirsher, netdev, linux-kernel
On Tue, 2011-10-25 at 22:19 +0200, Geert Uytterhoeven wrote:
> Hi Jeff,
>
> drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal Semiconductor
> (Now Cirrus Logic) CS89[02]0, so it belongs in drivers/net/ethernet/cirrus,
> next to cs89x0.c.
>
> And according to drivers/net/ethernet/apple/mace.h, "mace" is the
> "Am79C940 MACE (Medium Access Control for Ethernet)", so mace and
> macmace should be in drivers/net/ethernet/amd/.
The later is hard to tell for sure, it's coupled with an Apple DBDMA
chip and wired in odd ways, so ...
Ben.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/net/ethernet/apple
2011-10-27 7:45 ` drivers/net/ethernet/apple Jeff Kirsher
@ 2011-10-27 8:40 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2011-10-27 8:40 UTC (permalink / raw)
To: jeffrey.t.kirsher
Cc: Benjamin Herrenschmidt, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On Thu, Oct 27, 2011 at 09:45, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:
>> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal
>> Semiconductor
>> > (Now Cirrus Logic) CS89[02]0, so it belongs in
>> drivers/net/ethernet/cirrus,
>> > next to cs89x0.c.
>>
>> And on the first -next run since its inclusion:
>>
>> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
>> such file or directory
>>
>> it needs the (shared) header file which is in
>> drivers/net/ethernet/cirrus/.
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/
>
> Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
> drivers/net/ethernet/apple/ because it was grouped with the "common"
> drivers. The intent was to group drivers that use common code together.
>
> I can put together a patch to fix this if you are not able to.
I will create a patch to move mac89x0 to .../cirrus, when I get to compiling a
Mac kernel myself.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-27 8:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25 20:19 drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 5:16 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:45 ` drivers/net/ethernet/apple Jeff Kirsher
2011-10-27 8:40 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:46 ` drivers/net/ethernet/apple Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).