From: Geert Uytterhoeven <geert@linux-m68k.org>
To: David Miller <davem@davemloft.net>
Cc: danny.kukawka@bisect.de, dkukawka@suse.de,
jeffrey.t.kirsher@intel.com, jpirko@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier
Date: Tue, 28 Feb 2012 22:00:50 +0100 [thread overview]
Message-ID: <CAMuHMdUudso1YpukfxvGdb2fAYZBJewTgQEh-aU_KB0-U2o6WQ@mail.gmail.com> (raw)
In-Reply-To: <20120228.154914.662485432055205683.davem@davemloft.net>
Hi David,
2012/2/28 David Miller <davem@davemloft.net>:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Tue, 28 Feb 2012 21:45:30 +0100
>
>> drivers/net/ethernet/cirrus/mac89x0.c: In function ‘set_mac_address’:
>> drivers/net/ethernet/cirrus/mac89x0.c:597: warning: dereferencing
>> ‘void *’ pointer
>> drivers/net/ethernet/cirrus/mac89x0.c:597: error: request for member
>> ‘sa_data’ in something not a structure or union
>> drivers/net/ethernet/cirrus/mac89x0.c:600: warning: dereferencing
>> ‘void *’ pointer
>> drivers/net/ethernet/cirrus/mac89x0.c:600: error: request for member
>> ‘sa_data’ in something not a structure or union
>> drivers/net/ethernet/cirrus/mac89x0.c:595: warning: unused variable ‘saddr’
>
> Thanks, I've fixed this as follows and pushed to net-next:
>
> --------------------
> mac89x0: Fix build error.
>
> Need to use the new 'saddr' variable not the void 'addr' in
> set_mac_address().
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Thanks, that fixed the build.
What about the is_valid_ether_addr() check?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2012-02-28 21:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 13:45 [PATCH 00/11] print MAC via printk format specifier Danny Kukawka
2012-02-24 13:45 ` [PATCH 02/11] amd/hplance.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 03/11] cirrus/mac89x0: " Danny Kukawka
2012-02-25 10:15 ` Geert Uytterhoeven
2012-02-28 20:45 ` Geert Uytterhoeven
2012-02-28 20:49 ` David Miller
2012-02-28 21:00 ` Geert Uytterhoeven [this message]
2012-02-28 21:06 ` David Miller
2012-02-29 7:22 ` Danny Kukawka
2012-02-24 13:45 ` [PATCH 04/11] dec/tulip/de4x5: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 05/11] ixgbevf: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 06/11] sun/sunqe: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 07/11] xscale/ixp2000/ixpdev: " Danny Kukawka
2012-02-24 14:00 ` Lennert Buytenhek
2012-02-24 13:45 ` [PATCH 08/11] usb/cdc_ncm: " Danny Kukawka
2012-02-24 13:46 ` [PATCH 09/11] usb/kaweth: " Danny Kukawka
2012-02-24 13:56 ` Oliver Neukum
2012-02-24 20:42 ` [PATCH 00/11] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUudso1YpukfxvGdb2fAYZBJewTgQEh-aU_KB0-U2o6WQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=danny.kukawka@bisect.de \
--cc=davem@davemloft.net \
--cc=dkukawka@suse.de \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).