From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
"David S. Miller" <davem@davemloft.net>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Simon Horman" <horms+renesas@verge.net.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions
Date: Tue, 5 Dec 2017 10:39:57 +0100 [thread overview]
Message-ID: <CAMuHMdVG4X2E-FCVOxv+N_2gxwM=6RCmz8RS8FmZrXZadrFuXg@mail.gmail.com> (raw)
In-Reply-To: <20171205103835.6fb9192f@windsurf.lan>
Hi Thomas,
On Tue, Dec 5, 2017 at 10:38 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> On Tue, 5 Dec 2017 09:39:35 +0100, Geert Uytterhoeven wrote:
>> > Using 'ndev->dev.parent' (as in ravb) also should work... not sure which
>> > is better
>>
>> That was going to be my comment, too. I also haven't checked which
>> generates the smallest code.
>
> Using ndev->dev.parent actually generates bigger code (44 bytes larger) :
Thanks a lot for checking!
Gr{oetje,eeting}s,
Geert
next prev parent reply other threads:[~2017-12-05 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 13:33 [PATCH 0/2] net: sh_eth: DMA mapping API fixes Thomas Petazzoni
2017-12-04 13:33 ` [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions Thomas Petazzoni
2017-12-04 17:24 ` Sergei Shtylyov
2017-12-04 20:05 ` Sergei Shtylyov
2017-12-05 8:39 ` Geert Uytterhoeven
2017-12-05 9:38 ` Thomas Petazzoni
2017-12-05 9:39 ` Geert Uytterhoeven [this message]
2017-12-05 8:36 ` Geert Uytterhoeven
2017-12-04 13:33 ` [PATCH 2/2] net: sh_eth: don't use NULL as "struct device" for the DMA mapping API Thomas Petazzoni
2017-12-04 17:30 ` Sergei Shtylyov
2017-12-05 9:10 ` Geert Uytterhoeven
2017-12-05 19:42 ` [PATCH 0/2] net: sh_eth: DMA mapping API fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVG4X2E-FCVOxv+N_2gxwM=6RCmz8RS8FmZrXZadrFuXg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).