From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH net v4 01/13] net/8390: Remove redundant make dependencies Date: Mon, 12 Feb 2018 09:16:43 +0100 Message-ID: References: <46988f8227bd3ad617b5c7dd0ce8f159b75ffdb2.1518397634.git.fthain@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "David S. Miller" , netdev , "Linux/m68k" , Linux Kernel Mailing List , Greg Ungerer To: Finn Thain Return-path: In-Reply-To: <46988f8227bd3ad617b5c7dd0ce8f159b75ffdb2.1518397634.git.fthain@telegraphics.com.au> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Feb 12, 2018 at 4:08 AM, Finn Thain wrote: > The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and > have no need for 8390.o. modinfo confirms no dependency on 8390.ko. > Drop the redundant dependency from the Makefile. objdump confirms > that this has no effect on the module binaries. > > Cc: Greg Ungerer > Cc: Geert Uytterhoeven > Signed-off-by: Finn Thain Acked-by: Geert Uytterhoeven The superfluous additions of 8390.o were introduced in commit 644570b830266ff3 ("8390: Move the 8390 related drivers"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds