From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/3] ravb: fix shadowing of symbol 'stats' in ravb_get_ethtool_stats() Date: Mon, 16 Jul 2018 17:38:44 +0200 Message-ID: References: <20180716121927.21918-1-niklas.soderlund+renesas@ragnatech.se> <20180716121927.21918-2-niklas.soderlund+renesas@ragnatech.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: Sergei Shtylyov , netdev , Linux-Renesas To: =?UTF-8?Q?Niklas_S=C3=B6derlund?= Return-path: Received: from mail-vk0-f66.google.com ([209.85.213.66]:35558 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbeGPQGz (ORCPT ); Mon, 16 Jul 2018 12:06:55 -0400 In-Reply-To: <20180716121927.21918-2-niklas.soderlund+renesas@ragnatech.se> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 16, 2018 at 2:20 PM Niklas Söderlund wrote: > Inside a loop in ravb_get_ethtool_stats() a variable 'stats' is declared > resulting in the argument also named 'stats' to be shadowed. Fix this > warning by renaming the unused argument 'stats' to 'estats'. > > This fixes the sparse warning: > > ravb_main.c:1225:36: originally declared here > ravb_main.c:1233:41: warning: symbol 'stats' shadows an earlier one > > Signed-off-by: Niklas Söderlund Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds