From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/3] sh_eth: make sh_eth_soft_swap() work on ARM
Date: Mon, 4 Jun 2018 10:49:56 +0200 [thread overview]
Message-ID: <CAMuHMdViPmSvQtHLCkEKfESJ-Cop9bdUz=yq9pe=zFW3AiX15g@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVb2q=S6ucYCpwnVse-COefcuUGT6DO5Ympo+BjiVN9sg@mail.gmail.com>
On Mon, Jun 4, 2018 at 10:48 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sat, Jun 2, 2018 at 9:37 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
>> Browsing thru the driver disassembly, I noticed that ARM gcc generated
>> no code whatsoever for sh_eth_soft_swap() while building a little-endian
>> kernel -- apparently __LITTLE_ENDIAN__ was not being #define'd, however
>> it got implicitly #define'd when building with the SH gcc (I could only
>> find the explicit #define __LITTLE_ENDIAN that was #include'd when building
>> a little-endian kernel). Luckily, the Ether controller only doing big-
>> endian DMA is encountered on the early SH771x SoCs only and all ARM SoCs
>> implement EDMR.DE and thus set 'sh_eth_cpu_data::hw_swap'. But anyway, we
>> need to fix the #ifdef inside sh_eth_soft_swap() to something that would
>> work on all architectures...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Forgot to say: nice catch ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-06-04 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 19:32 [PATCH 0/3] sh_eth: fix & clean up sh_eth_soft_swap() Sergei Shtylyov
2018-06-02 19:37 ` [PATCH 1/3] sh_eth: make sh_eth_soft_swap() work on ARM Sergei Shtylyov
2018-06-04 8:48 ` Geert Uytterhoeven
2018-06-04 8:49 ` Geert Uytterhoeven [this message]
2018-06-02 19:38 ` [PATCH 2/3] sh_eth: uninline sh_eth_soft_swap() Sergei Shtylyov
2018-06-04 8:50 ` Geert Uytterhoeven
2018-06-02 19:40 ` [PATCH 3/3] sh_eth: use DIV_ROUND_UP() in sh_eth_soft_swap() Sergei Shtylyov
2018-06-04 8:55 ` Geert Uytterhoeven
2018-06-04 9:01 ` [PATCH 0/3] sh_eth: fix & clean up sh_eth_soft_swap() Geert Uytterhoeven
2018-06-04 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdViPmSvQtHLCkEKfESJ-Cop9bdUz=yq9pe=zFW3AiX15g@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).