From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/5] sh_eth: uninline sh_eth_tsu_get_offset() Date: Tue, 24 Jul 2018 08:46:44 +0200 Message-ID: References: <24093fd0-1b9b-a211-f988-0272483185d6@cogentembedded.com> <837a23c9-38d6-90af-ed0c-3ee2aaaa20f0@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: netdev , "David S. Miller" , Linux-Renesas To: Sergei Shtylyov Return-path: Received: from mail-vk0-f66.google.com ([209.85.213.66]:44963 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388286AbeGXHvw (ORCPT ); Tue, 24 Jul 2018 03:51:52 -0400 In-Reply-To: <837a23c9-38d6-90af-ed0c-3ee2aaaa20f0@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 23, 2018 at 8:10 PM Sergei Shtylyov wrote: > sh_eth_tsu_get_offset() is called several times by the driver, remove > *inline* and move that function from the header to the driver itself > to let gcc decide whether to expand it inline or not... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds