From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 2/4] net/macsonic: Drop redundant MACH_IS_MAC test
Date: Sun, 25 Feb 2018 10:51:58 +0100 [thread overview]
Message-ID: <CAMuHMdWDy=mjcHQGJYuxhTCrTKk0DkWhvJbW6K15Tbf6P6evcQ@mail.gmail.com> (raw)
In-Reply-To: <855f562229a4738706e30bcf232c58f14912f37e.1519514463.git.fthain@telegraphics.com.au>
On Sun, Feb 25, 2018 at 12:27 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> The MACH_IS_MAC test is redundant here because the platform device
> won't get registered unless MACH_IS_MAC.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-02-25 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 23:27 [PATCH net 0/4] Fixes, cleanup and modernization for SONIC ethernet drivers Finn Thain
2018-02-24 23:27 ` [PATCH net 1/4] net/macsonic: Convert to nubus_driver Finn Thain
2018-02-24 23:27 ` [PATCH net 4/4] net/sonic: Replace custom debug logging with netif_* calls Finn Thain
2018-02-24 23:27 ` [PATCH net 3/4] net/sonic: Clean up and modernize log messages Finn Thain
2018-02-24 23:27 ` [PATCH net 2/4] net/macsonic: Drop redundant MACH_IS_MAC test Finn Thain
2018-02-25 9:51 ` Geert Uytterhoeven [this message]
2018-02-26 19:46 ` [PATCH net 0/4] Fixes, cleanup and modernization for SONIC ethernet drivers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWDy=mjcHQGJYuxhTCrTKk0DkWhvJbW6K15Tbf6P6evcQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).