From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 3/3 RFC] Revert "net: stmmac: fix build failure due to missing COMMON_CLK dependency" Date: Mon, 11 Jun 2018 11:13:30 +0200 Message-ID: References: <1528706663-20670-1-git-send-email-geert@linux-m68k.org> <1528706663-20670-4-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Greg Ungerer , Ralf Baechle , James Hogan , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Corentin Labbe , "David S. Miller" , linux-m68k , Linux MIPS Mailing List , netdev , Linux Kernel Mailing List To: Arnd Bergmann Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Arnd, On Mon, Jun 11, 2018 at 10:59 AM Arnd Bergmann wrote: > On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven > wrote: > > This reverts commit bde4975310eb1982bd0bbff673989052d92fd481. > > > > All legacy clock implementations now implement clk_set_rate() (Some > > implementations may be dummies, though). > > > > Signed-off-by: Geert Uytterhoeven > > --- > > Marked "RFC", as this depends on "m68k: coldfire: Normalize clk API" and > > "MIPS: AR7: Normalize clk API". > > This seems reasonable. It's possible that it will cause regressions because the > COMMON_CLK dependency hides another dependency on something else > that not everything implements, but we should fix that properly if that happens. Compile-testing was enabled 2 years ago, in commit 2e280c188f06b190 ("stmmac: make platform drivers depend on their associated SoC"), but the dependency on COMMON_CLK was added only recently. That's what triggered me: the drivers were suddenly disabled in m68k allmodconfig, while they built fine for years before. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds