From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral Date: Tue, 23 May 2017 11:36:47 +0200 Message-ID: References: <1495112345-24795-1-git-send-email-geert+renesas@glider.be> <20170518193453.GB13759@lunn.ch> <08a89dd5-b707-8b8f-b8e1-e20b9ed630b7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Andrew Lunn , Geert Uytterhoeven , Rob Herring , Frank Rowand , Thomas Petazzoni , Sergei Shtylyov , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux-Renesas , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Florian Fainelli Return-path: In-Reply-To: <08a89dd5-b707-8b8f-b8e1-e20b9ed630b7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Florian, On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli wrote: > On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: >> On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: >>>>> This most certainly works fine in the simple case where you have one PHY >>>>> hanging off the MDIO bus, now what happens if you have several? >>>>> >>>>> Presumably, the first PHY that returns EPROBE_DEFER will make the entire >>>>> bus registration return EPROB_DEFER as well, and so on, and so forth, >>>>> but I am not sure if we will be properly unwinding the successful >>>>> registration of PHYs that either don't have an interrupt, or did not >>>>> return EPROBE_DEFER. >>>>> >>>>> It should be possible to mimic this behavior by using the fixed PHY, and >>>>> possibly the dsa_loop.c driver which would create 4 ports, expecting 4 >>>>> fixed PHYs to be present. >>>> >>>> mdiobus_unregister(), called from of_mdiobus_register() on failure, >>>> should do the unwinding, right? >>>> >>>> And when the driver is reprobed, all PHYs are reprobed, until they all >>>> succeed. >>> >>> That is the theory. I looked at that while reviewing the patch. But >>> this has probably not been tested in anger. It would be good to test >>> this properly, with not just the first PHY returning -EPROBE_DEFER, to >>> really test the unwind. >> >> Unfortunately I don't have a board with multiple PHYs, so I cannot test >> that case. I tried adding a few dummy PHYs in DT, but that didn't work. So how can we proceed? I think the only way my patch can cause issues is because some systems may rely on EPROBE_DEFER errors being ignored. >> Does unbinding/rebinding a network driver with multiple PHYs currently >> work? Or module unload/reload? > > Usually there is a strict 1:1 mapping between a network device (not > driver) and a PHY device, switch drivers however, would have multiple > PHYs (one per port, aka net_deice). > > NB: binding and unbinding of PHYs is pretty broken at the moment though, > because there is a complete disconnect between what the Ethernet MAC > expects, and the state in which the PHY is. I had some patches to fix > that, but this turned out to be playing whack-a-mole which I typically > suck at. I didn't mean unbinding the PHY, but the network device. Don't you have the same issue with the state of PHYs as left by the bootloader? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html