From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 2/5] sh_eth: make sh_eth_tsu_get_offset() match its name Date: Tue, 24 Jul 2018 08:48:08 +0200 Message-ID: References: <24093fd0-1b9b-a211-f988-0272483185d6@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: netdev , "David S. Miller" , Linux-Renesas To: Sergei Shtylyov Return-path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:33465 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388293AbeGXHxQ (ORCPT ); Tue, 24 Jul 2018 03:53:16 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 23, 2018 at 8:11 PM Sergei Shtylyov wrote: > sh_eth_tsu_get_offset(), despite its name, returns a TSU register's address, > not its offset. Make this function match its name and return a register's > offset from the TSU registers base address instead. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds