From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2] drivers: net: xgene: Rewrite loop in xgene_enet_ecc_init() Date: Wed, 22 Oct 2014 21:50:06 +0200 Message-ID: References: <1413963581-24019-1-git-send-email-geert@linux-m68k.org> <20141022.153436.93475594748933547.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: isubramanian@apm.com, kchudgar@apm.com, "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: David Miller Return-path: In-Reply-To: <20141022.153436.93475594748933547.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Oct 22, 2014 at 9:34 PM, David Miller wro= te: > From: Geert Uytterhoeven > Date: Wed, 22 Oct 2014 09:39:41 +0200 > >> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function =E2=80= =98xgene_enet_ecc_init=E2=80=99: >> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: =E2=80= =98data=E2=80=99 may be used uninitialized in this function >> >> Depending on the arbitrary value on the stack, the loop may terminat= e >> too early, and cause a bogus -ENODEV failure. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: Rewrite the loop instead of pre-initializing data. > > I hate to be a pest, but like the other patch of your's I think > a do { } while() works best here because the intent is clearly > to run the loop at least once, right? I wanted to avoid checking for "data !=3D ~0U" twice: once to abort the= loop, and once to check if a timeout happened. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. -- Linus Torvalds