netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Vazquez <brianvv@google.com>
To: "Hay, Joshua A" <joshua.a.hay@intel.com>
Cc: Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
	 "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	 "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>,
	 "Chittim, Madhu" <madhu.chittim@intel.com>,
	 "Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>,
	Willem de Bruijn <willemb@google.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>
Subject: Re: [PATCH net-next] idpf: do not linearize big TSO packets
Date: Thu, 21 Aug 2025 10:14:28 -0400	[thread overview]
Message-ID: <CAMzD94SjV35aPV5tUxKNEfpAk36yjZMQJz63bSnMeshHc8BSBQ@mail.gmail.com> (raw)
In-Reply-To: <DM4PR11MB6502871B0C99047AC76827BCD433A@DM4PR11MB6502.namprd11.prod.outlook.com>

Tested-by: Brian Vazquez <brianvv@google.com>


On Wed, Aug 20, 2025 at 12:27 AM Hay, Joshua A <joshua.a.hay@intel.com> wrote:
>
> > From: Eric Dumazet <edumazet@google.com>
> >
> > idpf has a limit on number of scatter-gather frags
> > that can be used per segment.
> >
> > Currently, idpf_tx_start() checks if the limit is hit
> > and forces a linearization of the whole packet.
> >
> > This requires high order allocations that can fail
> > under memory pressure. A full size BIG-TCP packet
> > would require order-7 alocation on x86_64 :/
> >
> > We can move the check earlier from idpf_features_check()
> > for TSO packets, to force GSO in this case, removing the
> > cost of a big copy.
> >
> > This means that a linearization will eventually happen
> > with sizes smaller than one MSS.
> >
> > __idpf_chk_linearize() is renamed to idpf_chk_tso_segment()
> > and moved to idpf_lib.c
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> > Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Cc: Jacob Keller <jacob.e.keller@intel.com>
> > Cc: Madhu Chittim <madhu.chittim@intel.com>
> > Cc: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
> > Cc: Joshua Hay <joshua.a.hay@intel.com>
> > Cc: Brian Vazquez <brianvv@google.com>
> > Cc: Willem de Bruijn <willemb@google.com>
> > Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> > ---
> Reviewed-by: Joshua Hay <joshua.a.hay@intel.com>

  reply	other threads:[~2025-08-21 14:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 19:59 [PATCH net-next] idpf: do not linearize big TSO packets Eric Dumazet
2025-08-20  4:27 ` Hay, Joshua A
2025-08-21 14:14   ` Brian Vazquez [this message]
2025-08-22 16:02 ` Tony Nguyen
2025-08-22 17:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMzD94SjV35aPV5tUxKNEfpAk36yjZMQJz63bSnMeshHc8BSBQ@mail.gmail.com \
    --to=brianvv@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=joshua.a.hay@intel.com \
    --cc=kuba@kernel.org \
    --cc=madhu.chittim@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.kumar.linga@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).