From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Grundler Subject: Re: RTL8153 fails to get link after applying c7de7dec2 to 3.8 kernel Date: Thu, 20 Feb 2014 09:20:51 -0800 Message-ID: References: <6929A44AB95D46C6B919DDD537CDD37B@realtek.com.tw> <65183A93811745C58958ECBAD0B8E00F@realtek.com.tw> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Inki Yoo , netdev To: hayeswang Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:57148 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755317AbaBTRUw (ORCPT ); Thu, 20 Feb 2014 12:20:52 -0500 Received: by mail-ob0-f170.google.com with SMTP id wp4so335539obc.1 for ; Thu, 20 Feb 2014 09:20:51 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 19, 2014 at 8:00 PM, hayeswang wrote: > Grant Grundler [mailto:grundler@google.com] >> Sent: Thursday, February 20, 2014 8:08 AM >> To: hayeswang >> Cc: Inki Yoo; netdev >> Subject: Re: RTL8153 fails to get link after applying >> c7de7dec2 to 3.8 kernel >> >> On Fri, Feb 14, 2014 at 1:53 PM, Grant Grundler >> wrote: > [...] >> I will temporarily add the udev rule you previously >> posted in order to automate testing this until I can get HW that comes >> up in "vendor mode". > > Excuse me if I misunderstand your meaning. Our device has two > configurations and I don't think you would get one with vendor > mode only without ECM mode. Hayes, I expect the device to come up in a mode that "just works". I don't have an expectation of which mode that should be. Perhaps there is another bug that is causing the ECM mode (bConfigurationValue=2) to not work? > Besides, according to the information > from one of the maintainers of the kernel, when a USB device with > more than one configuration is plugged, the USB core would select > the configuration which is not vendor mode first if it exists. Ah ok. I didn't know that. that sounds reasonable....but it should work. The drivers clearly don't work with c7de7dec2 patch applied (and default device settings). > Therefore, it is reasonably considered that the configuration 2 > would be set by default for our device if you do nothing. Ok. I can't apply c7de7dec2 as-is to ChromeOS with the current behaviors. How would you like to see this fixed? Have the r815x driver flip the device to "Vendor Mode" and not claim it so r8152 driver can? Or you have any idea why ECM mode doesn't work with c7de7dec2 patch? cheers. grant