From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Linux NetDev <netdev@vger.kernel.org>, Erik Kline <ek@google.com>,
Lorenzo Colitti <lorenzo@google.com>
Subject: Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1
Date: Tue, 4 Oct 2016 15:40:30 +0900 [thread overview]
Message-ID: <CANP3RGdVquyFe1VA2mKMC1HNgnXPhmpsv45R-7P6boWCb8oC2A@mail.gmail.com> (raw)
In-Reply-To: <20161004.003831.2056791273400961514.davem@davemloft.net>
> Please remove the const qualifier and the casts to be consistent
> with how we handle this elsewhere.
>
> Thanks.
I can of course trivially make that change.
But:
(on net-next/master)
git grep 'extra[12].*=.*\(void *[*]\)'
currently finds 45 matches, and this patch adds a 46th.
In particular there's a ton of such examples in:
drivers/parport/procfs.c
kernel/sysctl.c
net/rxrpc/sysctl.c
security/keys/sysctl.c
There's also the 2 that were added to:
net/ipv6/addrconf.c (ie. same file as this patch)
in my previous patch set.
Should I also remove void * from those as well?
Should this be left as is?
Marking it explicitly as const gets the constants into the rodata
section which is cpu page table masked to be read-only so it seems
much safer/better...
- Maciej
next prev parent reply other threads:[~2016-10-04 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 6:41 [PATCH] ipv6 addrconf: disallow rtr_solicits < -1 Maciej Żenczykowski
2016-10-03 19:49 ` Cong Wang
2016-10-03 20:01 ` Maciej Żenczykowski
2016-10-03 20:05 ` Cong Wang
2016-10-04 4:38 ` David Miller
2016-10-04 6:40 ` Maciej Żenczykowski [this message]
2016-10-07 0:53 ` Cong Wang
2016-10-07 8:00 ` [PATCH v2] " Maciej Żenczykowski
2016-10-08 3:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP3RGdVquyFe1VA2mKMC1HNgnXPhmpsv45R-7P6boWCb8oC2A@mail.gmail.com \
--to=zenczykowski@gmail.com \
--cc=davem@davemloft.net \
--cc=ek@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).