From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Ben Hutchings <ben@decadent.org.uk>,
"David S . Miller" <davem@davemloft.net>,
David Decotigny <decot@google.com>,
Linux NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct
Date: Fri, 14 Dec 2018 18:30:36 -0800 [thread overview]
Message-ID: <CANP3RGexaMYs76dxKnetfdXiXHFe306O7ZXjEvH-RNMJAn0sbw@mail.gmail.com> (raw)
In-Reply-To: <20181215022651.GJ21324@unicorn.suse.cz>
> The dmac member of struct ethtool_coalesce was removed by commit
> c0b078ce7e88 ("Revert "ethtool: Add DMA Coalescing support"") because it
> has never been added in kernel (as that would break compatibility with
> older ethtool versions).
Hmm, well, it doesn't hurt to zero init either way...
next prev parent reply other threads:[~2018-12-15 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 1:19 [PATCH] ethtool: zero initialize coalesce struct Maciej Żenczykowski
2018-12-15 2:26 ` Michal Kubecek
2018-12-15 2:30 ` Maciej Żenczykowski [this message]
2018-12-15 12:29 ` Ben Hutchings
2019-01-18 18:40 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP3RGexaMYs76dxKnetfdXiXHFe306O7ZXjEvH-RNMJAn0sbw@mail.gmail.com \
--to=zenczykowski@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=jgarzik@pobox.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).