From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= <zenczykowski@gmail.com>
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct
Date: Fri, 14 Dec 2018 18:30:36 -0800
Message-ID: <CANP3RGexaMYs76dxKnetfdXiXHFe306O7ZXjEvH-RNMJAn0sbw@mail.gmail.com>
References: <20181215011923.246179-1-zenczykowski@gmail.com> <20181215022651.GJ21324@unicorn.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Jeff Garzik <jgarzik@pobox.com>,
        Ben Hutchings <ben@decadent.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        David Decotigny <decot@google.com>,
        Linux NetDev <netdev@vger.kernel.org>
To: Michal Kubecek <mkubecek@suse.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ua1-f65.google.com ([209.85.222.65]:44258 "EHLO
        mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726609AbeLOCat (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 14 Dec 2018 21:30:49 -0500
Received: by mail-ua1-f65.google.com with SMTP id d19so2670024uaq.11
        for <netdev@vger.kernel.org>; Fri, 14 Dec 2018 18:30:49 -0800 (PST)
In-Reply-To: <20181215022651.GJ21324@unicorn.suse.cz>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> The dmac member of struct ethtool_coalesce was removed by commit
> c0b078ce7e88 ("Revert "ethtool: Add DMA Coalescing support"") because it
> has never been added in kernel (as that would break compatibility with
> older ethtool versions).

Hmm, well, it doesn't hurt to zero init either way...