From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
kernel test robot <lkp@intel.com>,
Yujie Liu <yujie.liu@intel.com>, Philip Li <philip.li@intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev,
Jacob Keller <jacob.e.keller@intel.com>,
intel-wired-lan@lists.osuosl.org,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs
Date: Fri, 18 Aug 2023 13:10:07 +0200 [thread overview]
Message-ID: <CANiq72m9ZEVkP76FMFOnPYkA8ih4Mq72HtW9AbrJ-JPy9ku3jw@mail.gmail.com> (raw)
In-Reply-To: <cfc29063-9e20-5101-d70b-62b5423d2d10@intel.com>
On Fri, Aug 18, 2023 at 12:38 PM Przemek Kitszel
<przemyslaw.kitszel@intel.com> wrote:
>
> Rust folks, could you please tell me if this is something I should fix,
> or I just uncovered some existing bug in "unstable" thing?
>
> Perhaps it is worth to mention, diff of v3 vs v2 is:
> move dummy implementation of __has_builtin() macro to the top of
> compiler_types.h, just before `#ifndef ASSEMBLY`
Nothing you need to worry about, it is an issue with old `bindgen` and
LLVM >= 16, fixed in commit 08ab786556ff ("rust: bindgen: upgrade to
0.65.1") which is in `rust-next` at the moment. Sorry about that, and
thanks for pinging us!
LKP / Yujie / Philip: since we got a few reports on this, would it be
possible to avoid LLVM >= 16 for Rust-enabled builds for any branch
that does not include the new `bindgen` or at least 08ab786556ff? Or,
if Greg is OK with that, I guess we could also backport the upgrade,
but perhaps it is a bit too much for stable?
Cheers,
Miguel
next prev parent reply other threads:[~2023-08-18 11:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 14:06 [PATCH net-next v3 0/7] introduce DEFINE_FLEX() macro Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs Przemek Kitszel
2023-08-16 16:35 ` kernel test robot
2023-08-18 10:37 ` Przemek Kitszel
2023-08-18 11:10 ` Miguel Ojeda [this message]
2023-08-18 12:07 ` Philip Li
2023-08-19 10:06 ` Greg KH
2023-08-16 20:38 ` Kees Cook
2023-08-17 14:35 ` David Laight
2023-08-17 17:00 ` Kees Cook
2023-08-18 7:14 ` David Laight
2023-08-18 10:28 ` Przemek Kitszel
2023-08-18 10:49 ` David Laight
2023-08-23 20:52 ` Przemek Kitszel
2023-08-28 14:41 ` Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 2/7] ice: ice_sched_remove_elems: replace 1 elem array param by u32 Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 3/7] ice: drop two params of ice_aq_move_sched_elems() Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 4/7] ice: make use of DEFINE_FLEX() in ice_ddp.c Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 5/7] ice: make use of DEFINE_FLEX() for struct ice_aqc_add_tx_qgrp Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 6/7] ice: make use of DEFINE_FLEX() for struct ice_aqc_dis_txq_item Przemek Kitszel
2023-08-16 14:06 ` [PATCH net-next v3 7/7] ice: make use of DEFINE_FLEX() in ice_switch.c Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72m9ZEVkP76FMFOnPYkA8ih4Mq72HtW9AbrJ-JPy9ku3jw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=philip.li@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).