Re: [PATCH net-next 1/4] net_sched: remove BH blocking in eight actions

[Eric Dumazet <edumazet@google.com>]

On Thu, Aug 28, 2025 at 8:29 PM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
> On Thu, Aug 28, 2025 at 11:26 PM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >
> > On Wed, Aug 27, 2025 at 8:53 AM Eric Dumazet <edumazet@google.com> wrote:
> > >
> > > Followup of f45b45cbfae3 ("Merge branch
> > > 'net_sched-act-extend-rcu-use-in-dump-methods'")
> > >
> > > We never grab tcf_lock from BH context in these modules:
> > >
> > >  act_connmark
> > >  act_csum
> > >  act_ct
> > >  act_ctinfo
> > >  act_mpls
> > >  act_nat
> > >  act_pedit
> > >  act_skbedit
> > >
> > > No longer block BH when acquiring tcf_lock from init functions.
> > >
> >
> > Brief glance: isnt  the lock still held in BH context for some actions
> > like pedit and nat (albeit in corner cases)? Both actions call
> > tcf_action_update_bstats in their act callbacks.
> > i.e if the action instance was not created with percpu stats,
> > tcf_action_update_bstats will grab the lock.
> >
>
> Testing with lockdep should illustrate this..

Thanks, I will take a look shortly !