From: Eric Dumazet <edumazet@google.com>
To: Ziran Zhang <zhangcoder@yeah.net>
Cc: Neal Cardwell <ncardwell@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator()
Date: Thu, 3 Sep 2026 12:21:45 +0200 [thread overview]
Message-ID: <CANn89i+LS8aefxHe7MvV7DZ7kSWrLPQpfB-OHa76O_jm8_fbYA@mail.gmail.com> (raw)
In-Reply-To: <20260903101256.8879-1-zhangcoder@yeah.net>
On Thu, Sep 3, 2026 at 12:13 PM Ziran Zhang <zhangcoder@yeah.net> wrote:
>
> The old comment "mdev = 3/4 mdev + 1/4 new" only describes the
> common case. However, when RTT decreases and |rtt - srtt| > mdev/4,
> the code applies a finer gain of 1/32 instead of 1/4, resulting in:
> mdev = 31/32 mdev + 1/32 * new.
>
> Express both cases with a unified formula using variable
> gain g.
>
> Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
We asked you to leave this comment as it is. Thank you.
pw-bot: rejected
next prev parent reply other threads:[~2026-09-03 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 10:12 [PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator() Ziran Zhang
2026-09-03 10:21 ` Eric Dumazet [this message]
2026-09-03 10:36 ` Ziran Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89i+LS8aefxHe7MvV7DZ7kSWrLPQpfB-OHa76O_jm8_fbYA@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangcoder@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox