* [PATCH] net: tcp_ipv4.c: Add missing space
@ 2025-08-04 14:39 Osama Albahrani
2025-08-04 14:51 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Osama Albahrani @ 2025-08-04 14:39 UTC (permalink / raw)
To: Eric Dumazet, Neal Cardwell, Kuniyuki Iwashima, David S. Miller,
David Ahern, Jakub Kicinski, Paolo Abeni, Simon Horman, netdev,
linux-kernel
Cc: Osama Albahrani
This commit resolves the following checkpatch.pl error:
```
ERROR: spaces required around that '=' (ctx:VxW)
+ .twsk_destructor= tcp_twsk_destructor,
^
```
Assuming the purpose was to align the equal signs, I also added a space in
the previous line.
Signed-off-by: Osama Albahrani <osalbahr@gmail.com>
---
net/ipv4/tcp_ipv4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 84d3d556ed80..2585e176b031 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2458,8 +2458,8 @@ int tcp_v4_rcv(struct sk_buff *skb)
}
static struct timewait_sock_ops tcp_timewait_sock_ops = {
- .twsk_obj_size = sizeof(struct tcp_timewait_sock),
- .twsk_destructor= tcp_twsk_destructor,
+ .twsk_obj_size = sizeof(struct tcp_timewait_sock),
+ .twsk_destructor = tcp_twsk_destructor,
};
void inet_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: tcp_ipv4.c: Add missing space
2025-08-04 14:39 [PATCH] net: tcp_ipv4.c: Add missing space Osama Albahrani
@ 2025-08-04 14:51 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2025-08-04 14:51 UTC (permalink / raw)
To: Osama Albahrani
Cc: Neal Cardwell, Kuniyuki Iwashima, David S. Miller, David Ahern,
Jakub Kicinski, Paolo Abeni, Simon Horman, netdev, linux-kernel
On Mon, Aug 4, 2025 at 7:39 AM Osama Albahrani <osalbahr@gmail.com> wrote:
>
> This commit resolves the following checkpatch.pl error:
>
> ```
> ERROR: spaces required around that '=' (ctx:VxW)
> + .twsk_destructor= tcp_twsk_destructor,
> ^
> ```
>
> Assuming the purpose was to align the equal signs, I also added a space in
> the previous line.
>
> Signed-off-by: Osama Albahrani <osalbahr@gmail.com>
> ---
I have a patch removing .twsk_destructor completely, waiting for
net-next to open next week.
(DCCP has been removed a while ago)
So I would vote for not bothering with your patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-04 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-04 14:39 [PATCH] net: tcp_ipv4.c: Add missing space Osama Albahrani
2025-08-04 14:51 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).