netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: export symnbol for skb_attempt_defer_free
@ 2025-09-01 18:16 John Ousterhout
  2025-09-01 18:44 ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: John Ousterhout @ 2025-09-01 18:16 UTC (permalink / raw)
  To: netdev; +Cc: pabeni, edumazet, horms, kuba, John Ousterhout

This function is useful for modules such as Homa but is not
currently visible.

Signed-off-by: John Ousterhout <ouster@cs.stanford.edu>
---
 net/core/skbuff.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 9153a6ba0fcb..4aaebff26f50 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -7255,6 +7255,7 @@ nodefer:	kfree_skb_napi_cache(skb);
 	if (unlikely(kick))
 		kick_defer_list_purge(sd, cpu);
 }
+EXPORT_SYMBOL(skb_attempt_defer_free);
 
 static void skb_splice_csum_page(struct sk_buff *skb, struct page *page,
 				 size_t offset, size_t len)
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: export symnbol for skb_attempt_defer_free
  2025-09-01 18:16 [PATCH] net: export symnbol for skb_attempt_defer_free John Ousterhout
@ 2025-09-01 18:44 ` Jakub Kicinski
  2025-09-01 18:55   ` Eric Dumazet
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-09-01 18:44 UTC (permalink / raw)
  To: John Ousterhout; +Cc: netdev, pabeni, edumazet, horms

On Mon,  1 Sep 2025 11:16:23 -0700 John Ousterhout wrote:
> This function is useful for modules such as Homa but is not
> currently visible.

It has to be part of the series which contains an in tree user.
We only export symbols for in-tree modules.
-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: export symnbol for skb_attempt_defer_free
  2025-09-01 18:44 ` Jakub Kicinski
@ 2025-09-01 18:55   ` Eric Dumazet
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2025-09-01 18:55 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: John Ousterhout, netdev, pabeni, horms

On Mon, Sep 1, 2025 at 11:44 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon,  1 Sep 2025 11:16:23 -0700 John Ousterhout wrote:
> > This function is useful for modules such as Homa but is not
> > currently visible.
>
> It has to be part of the series which contains an in tree user.
> We only export symbols for in-tree modules.

Also if homa does not have yet GRO support, I doubt
skb_attempt_defer_free() is a big win.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-01 18:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 18:16 [PATCH] net: export symnbol for skb_attempt_defer_free John Ousterhout
2025-09-01 18:44 ` Jakub Kicinski
2025-09-01 18:55   ` Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).