From: Eric Dumazet <edumazet@google.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 3/3] net: add NUMA awareness to skb_attempt_defer_free()
Date: Sun, 28 Sep 2025 01:45:00 -0700 [thread overview]
Message-ID: <CANn89iJ9=dv2=itEKAyhBVY6edkYRLCuGLbgt_vMNpohNU00rQ@mail.gmail.com> (raw)
In-Reply-To: <CAAVpQUDiGuCtUzXeJw0004VxDHFketF7J+Xu6tqEod_o=3r7Kg@mail.gmail.com>
On Sat, Sep 27, 2025 at 1:28 PM Kuniyuki Iwashima <kuniyu@google.com> wrote:
>
> On Fri, Sep 26, 2025 at 8:13 AM Eric Dumazet <edumazet@google.com> wrote:
> >
> > Instead of sharing sd->defer_list & sd->defer_count with
> > many cpus, add one pair for each NUMA node.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > -static void skb_defer_free_flush(struct softnet_data *sd)
> > +struct skb_defer_node __percpu *skb_defer_nodes;
>
> seems this is unused, given it's close to the end of cycle
> maybe this can be fixed up while applying ? :)
Good catch, I moved it to net_hotdata but forgot to remove this leftover.
Will send a V2.
Thanks.
prev parent reply other threads:[~2025-09-28 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 15:13 [PATCH net-next 0/3] net: lockless skb_attempt_defer_free() Eric Dumazet
2025-09-26 15:13 ` [PATCH net-next 1/3] net: make softnet_data.defer_count an atomic Eric Dumazet
2025-09-27 1:10 ` Jason Xing
2025-09-27 19:39 ` Kuniyuki Iwashima
2025-09-26 15:13 ` [PATCH net-next 2/3] net: use llist for sd->defer_list Eric Dumazet
2025-09-27 1:09 ` Jason Xing
2025-09-27 19:52 ` Kuniyuki Iwashima
2025-09-26 15:13 ` [PATCH net-next 3/3] net: add NUMA awareness to skb_attempt_defer_free() Eric Dumazet
2025-09-27 1:33 ` Jason Xing
2025-09-27 20:28 ` Kuniyuki Iwashima
2025-09-28 8:45 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iJ9=dv2=itEKAyhBVY6edkYRLCuGLbgt_vMNpohNU00rQ@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).