From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8161DDB8 for ; Mon, 7 Aug 2023 13:27:21 +0000 (UTC) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B84D1BF4 for ; Mon, 7 Aug 2023 06:27:02 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-40a47e8e38dso438641cf.1 for ; Mon, 07 Aug 2023 06:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691414768; x=1692019568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aV86SNTrsedHb/4GViYCEi4y0WkKBp0siTYx3zahDc8=; b=4S7gV7c2cdcuEpB2T5mX/CpOL0kpeYdnmSvNbTa56EyndJ1AvAzRNKOCHIXMgx0KOG m3pW2Po9Xpwb5mBlkkTlDX7BdfoeEdLud2EtxxftfD36WTiHHe2nEeXaITwz2BDbbA0E mSvp6S22gXS5JjA4PzFAz3yxbfL/xwTpchOOFlQes8Q9oNXqFc9aOWbePypmk7q1dk4A a4vRst4pzFXh9rN/C4cxoJLZMGwpmyH5jRV3WLEwpNBiRYis7cS9NoowQ/CtsnQCP+xr DEBbVtZs2zdvHzsuMXpeRoX/6pa4fjpkmdII9AdqLI15u6AO9N5fAAXHrXdcgBZmZLKS kpZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691414768; x=1692019568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aV86SNTrsedHb/4GViYCEi4y0WkKBp0siTYx3zahDc8=; b=HdCN9g1LacrbSDNr+eAHgAbY7FmqyUKB47ZXXzAY3JBWeaP34H1sRgSO/FC8yUB/aG mz9mtwUgMoJskdodc7FByST1fXPINS7+mCYFL8MVOJZxdcFr18P6x0cE8sHHyewquvdQ dvDniJMuq/IrtVXdusgz6QPUdhfGRRKkJnxyIP9CA1gHgQ8t0vRfxn8kpRx29DnEeTNC nrl6CmI5I4hL5EYGnv6WeukX0EjnXUzYz1+p+hnS3fqrrf095UWsIqoCZtp5zpEZ9371 QheSRja2MSfGvDyxHLKwpXPTs0repw4w6VdLF769vKu1x0y4KZB8GCb32uBsjEK0uIl5 YsaQ== X-Gm-Message-State: AOJu0Yx5tG3M6HK5JOwZNaRwY/6Tb4pjNNmnGawQLoLfzOlJXwN/yYQ+ H577yiuPj8ZSDyvQjSZ/y6qdIoaAiD2lyVCRjfNJvg== X-Google-Smtp-Source: AGHT+IH7l8fz/va80d2V76Roj1BsoAMY57SE1UROxLkV3dyWOxXlttc6h2gDN6ZO1f9HDD+7BbQ8h6jdtiwhSOmFGN4= X-Received: by 2002:a05:622a:1806:b0:403:ac17:c18a with SMTP id t6-20020a05622a180600b00403ac17c18amr454405qtc.14.1691414768116; Mon, 07 Aug 2023 06:26:08 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230806075216.13378-1-me@manjusaka.me> <8d25f9e8-9653-4e9b-b88b-c5434ce8aabf@app.fastmail.com> In-Reply-To: <8d25f9e8-9653-4e9b-b88b-c5434ce8aabf@app.fastmail.com> From: Eric Dumazet Date: Mon, 7 Aug 2023 15:25:56 +0200 Message-ID: Subject: Re: [PATCH] [RFC PATCH] tcp event: add new tcp:tcp_cwnd_restart event To: Manjusaka Cc: mhiramat@kernel.org, rostedt@goodmis.org, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Aug 7, 2023 at 2:49=E2=80=AFPM Manjusaka wrote: > > > Do not include code before variable declarations. > Sorry about that. I will update the code later. > > > I would rather add a trace in tcp_ca_event(), this would be more generi= c ? > > https://elixir.bootlin.com/linux/latest/source/net/ipv4/tcp_cong.c#L41 > > I think maybe we already have the tcp_ca_event but named tcp_cong_state_s= et? I am speaking of tcp_ca_event()... For instance, tcp_cwnd_restart() calls tcp_ca_event(sk, CA_EVENT_CWND_RESTA= RT); tcp_set_ca_state() can only set icsk_ca_state to one value from enum tcp_ca_state: TCP_CA_Open, TCP_CA_Disorder, TCP_CA_CWR, TCP_CA_Recovery, TCP_CA_Loss enum tcp_ca_event has instead: CA_EVENT_TX_START, CA_EVENT_CWND_RESTART, CA_EVENT_COMPLETE_CWR, CA_EVENT_LOSS, CA_EVENT_ECN_NO_CE, CA_EVENT_ECN_IS_CE