From: Eric Dumazet <edumazet@google.com>
To: Haiyang Zhang <haiyangz@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
haiyangz@microsoft.com, kys@microsoft.com, wei.liu@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
davem@davemloft.net, sdf@fomichev.me, kuniyu@google.com,
ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
#@linux.microsoft.com, 5.4+@linux.microsoft.com
Subject: Re: [PATCH net] net: core: Fix the loop in default_device_exit_net()
Date: Mon, 21 Jul 2025 23:51:51 -0700 [thread overview]
Message-ID: <CANn89iJLnprFvLpRpJ7_br5EiyCF0xqcMM7seUVQNAfroc4Taw@mail.gmail.com> (raw)
In-Reply-To: <1752870014-28909-1-git-send-email-haiyangz@linux.microsoft.com>
On Fri, Jul 18, 2025 at 1:21 PM Haiyang Zhang
<haiyangz@linux.microsoft.com> wrote:
>
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> The loop in default_device_exit_net() won't be able to properly detect the
> head then stop, and will hit NULL pointer, when a driver, like hv_netvsc,
> automatically moves the slave device together with the master device.
>
> To fix this, add a helper function to return the first migratable netdev
> correctly, no matter one or two devices were removed from this net's list
> in the last iteration.
>
> Cc: stable@vger.kernel.org # 5.4+
We (network maintainers) prefer a Fixes: tag, so that we can look at
the blamed patch, rather than trusting your '5.4' hint.
Without a Fixes tag, you are forcing each reviewer to do the
archeology work, and possibly completely miss your point.
next prev parent reply other threads:[~2025-07-22 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 20:20 [PATCH net] net: core: Fix the loop in default_device_exit_net() Haiyang Zhang
2025-07-18 23:37 ` Jakub Kicinski
2025-07-19 20:47 ` Kuniyuki Iwashima
2025-07-22 16:20 ` [EXTERNAL] " Haiyang Zhang
2025-07-22 6:51 ` Eric Dumazet [this message]
2025-07-22 16:15 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJLnprFvLpRpJ7_br5EiyCF0xqcMM7seUVQNAfroc4Taw@mail.gmail.com \
--to=edumazet@google.com \
--cc=#@linux.microsoft.com \
--cc=5.4+@linux.microsoft.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=haiyangz@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).