From: Eric Dumazet <edumazet@google.com>
To: Mahesh Bandewar <mahesh@bandewar.net>
Cc: David Miller <davem@davemloft.net>,
Mahesh Bandewar <maheshb@google.com>,
Tim Hockin <thockin@google.com>, netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tim Hockins <thockins@google.com>
Subject: Re: [PATCH next] ipvlan: inherit MTU from master device
Date: Thu, 28 Jan 2016 05:13:02 -0800 [thread overview]
Message-ID: <CANn89iJXmdaq=Rc20QriH+QL8Nug_g4zRUO8BFw04pdAWQ6BEA@mail.gmail.com> (raw)
In-Reply-To: <1453966408-16343-1-git-send-email-mahesh@bandewar.net>
On Wed, Jan 27, 2016 at 11:33 PM, Mahesh Bandewar <mahesh@bandewar.net> wrote:
> From: Mahesh Bandewar <maheshb@google.com>
>
> When we create IPvlan slave; we use ether_setup() and that
> sets up default MTU to 1500 while the master device may have
> lower / different MTU. Any subsequent changes to the masters'
> MTU are reflected into the slaves' MTU setting. However if those
> don't happen (most likely scenario), the slaves' MTU stays at
> 1500 which could be bad.
>
> This change adds code to inherit MTU from the master device
> instead of using the default value during the link initialization
> phase.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> CC: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Tim Hockins <thockins@google.com>
>
Acked-by: Eric Dumazet <edumazet@google.com>
Two points Mahesh :
1) ipvlan_adjust_mtu() could be static, it is only used from
drivers/net/ipvlan/ipvlan_main.c
2) mtu_adj does not seem to be used ?
next prev parent reply other threads:[~2016-01-28 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 7:33 [PATCH next] ipvlan: inherit MTU from master device Mahesh Bandewar
2016-01-28 13:13 ` Eric Dumazet [this message]
2016-01-28 17:04 ` Mahesh Bandewar
2016-02-05 0:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iJXmdaq=Rc20QriH+QL8Nug_g4zRUO8BFw04pdAWQ6BEA@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=thockin@google.com \
--cc=thockins@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).