From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D9DC169C4 for ; Thu, 31 Jan 2019 19:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EC9F218AF for ; Thu, 31 Jan 2019 19:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="h0THRKnl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbfAaTmR (ORCPT ); Thu, 31 Jan 2019 14:42:17 -0500 Received: from mail-yw1-f66.google.com ([209.85.161.66]:41605 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbfAaTmR (ORCPT ); Thu, 31 Jan 2019 14:42:17 -0500 Received: by mail-yw1-f66.google.com with SMTP id f65so1753467ywc.8 for ; Thu, 31 Jan 2019 11:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/7pxGxQl4Kqt0UFBEZYGUX8wNCNTExDP4tshNQqE+IM=; b=h0THRKnlOOZ/M/EiI1xPLUxoChLLVOTJK0Vypq3QNricwVGe73EbNI56azK1LC+38Y AFa1XdVWEVw6rA7yw0stzFG/h5Wo+e50PWWqpjuu3mahAAe33VXZZN08BNeQVTJOzZK5 vo0JIeNLKPdOipaqeKNKrfBAl1KIWzbTKh/F/IU0nCANZCEf+mucIqZ7XzvtTsqN7U+0 uqJESyhRDJ5DwxkLZFftTAlPQnKlpPp9rB/mLU9js40xkjV3dKTiDbXR1pU2WP8nquua gqmYmLoIU6/nUawgTYxYgQ2268sXEfmzjUmcrdZ+firyS2zvFL9xoFRZEnCWP7LkLVtN U8oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/7pxGxQl4Kqt0UFBEZYGUX8wNCNTExDP4tshNQqE+IM=; b=l4lr1Ppsgm6FuFQM6fNFPOopLkpNZsxXQcWfLjeKNiI2V9pyQ/TyO01BOmENib/HFS SKXhT9XQd+3vI58xRAkXvNIghWwKEvbo/IVJ8X1JanTu/GPq86M41VdMWXl3HATwc8cW ahjLLiH6hiARDNlNah8B1p4mqWe+5HBl/pcHmd7Jv1HF90kq9OMkiQAWaQbgcFYx1usu ViAzv923Ma8helaBgaFgvg+sXTw/Yzn1+Ij21Z6PWLSYiyz69lIC7/Fi9qeAv60AwFgF fYTGN5ElsLtO0OxWxU+DfcqvzJJXymUhV21QUaQbM66QrcM+VT8kgO8hA33Ble2PcBOh mE8Q== X-Gm-Message-State: AJcUukc/HLAepR9VznZie5ygcb2Z9zJ8S7uMlPUKMOHd+NvfCZ6eMnm6 VLL7c1FmrVmzGEzRaiJAkGkRnUWOpCac0vpBJ4rAeifszq/pUw== X-Google-Smtp-Source: ALg8bN7TY3bZMaj3LZ6npsTYNeHnNgLmOORHs3L7dRiHpTaTknfObPFZQsr5NXpglt2K7VYv5eX1juTUSNhAxY+7NmU= X-Received: by 2002:a81:6189:: with SMTP id v131mr34912539ywb.37.1548963736052; Thu, 31 Jan 2019 11:42:16 -0800 (PST) MIME-Version: 1.0 References: <1548939763-20074-1-git-send-email-tariqt@mellanox.com> <7520daf2c35b485660474c6e76a9ad4e24dc817e.camel@mellanox.com> In-Reply-To: <7520daf2c35b485660474c6e76a9ad4e24dc817e.camel@mellanox.com> From: Eric Dumazet Date: Thu, 31 Jan 2019 11:42:04 -0800 Message-ID: Subject: Re: [PATCH net] net/mlx4_en: Force CHECKSUM_NONE for short ethernet frames To: Saeed Mahameed Cc: Eran Ben Elisha , "davem@davemloft.net" , "netdev@vger.kernel.org" , Tariq Toukan Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 31, 2019 at 11:27 AM Saeed Mahameed wrote: > > Are you sure ? you are claiming that the hardware will skip csum > complete i.e cqe->checksum will be 0xffff for padded short IP frames. > i don't think this is the case, the whole bug is that the hw does > provide a partial cqe->checksum (i.e doesn't included the padding > bytes) even for short eth frames. If the padding is not included, then cqe->checksum is 0xFFFF for correctly received frames. Otherwise, what would be cqe->checksum in this case ? A random value ?