From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f171.google.com ([209.85.128.171]:43586 "EHLO
        mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753147AbeB1QqM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Feb 2018 11:46:12 -0500
Received: by mail-wr0-f171.google.com with SMTP id u49so3112712wrc.10
        for <netdev@vger.kernel.org>; Wed, 28 Feb 2018 08:46:11 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20180228.114240.1711766040670948234.davem@davemloft.net>
References: <20180227233218.158382-1-soheil.kdev@gmail.com> <20180228.114240.1711766040670948234.davem@davemloft.net>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 28 Feb 2018 08:46:09 -0800
Message-ID: <CANn89iKjToT20XZ2YbDSrXdLkP=SEj6K14CRmw=g-nLjncCh7Q@mail.gmail.com>
Subject: Re: [PATCH net] tcp: purge write queue upon RST
To: David Miller <davem@davemloft.net>
Cc: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        Willem de Bruijn <willemb@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        Neal Cardwell <ncardwell@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Feb 28, 2018 at 8:42 AM, David Miller <davem@davemloft.net> wrote:
> From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
> Date: Tue, 27 Feb 2018 18:32:18 -0500
>
>> From: Soheil Hassas Yeganeh <soheil@google.com>
>>
>> When the connection is reset, there is no point in
>> keeping the packets on the write queue until the connection
>> is closed.
>>
>> RFC 793 (page 70) and RFC 793-bis (page 64) both suggest
>> purging the write queue upon RST:
>> https://tools.ietf.org/html/draft-ietf-tcpm-rfc793bis-07
>>
>> Moreover, this is essential for a correct MSG_ZEROCOPY
>> implementation, because userspace cannot call close(fd)
>> before receiving zerocopy signals even when the connection
>> is reset.
>>
>> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
>> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
>> Reviewed-by: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>> Signed-off-by: Neal Cardwell <ncardwell@google.com>
>
> This is one of those "yeah, why have we been doing this all of
> this time?" kind of situation.
>
> Let's hope there isn't some subtle side effect, but indeed this
> current behavior is broken for MSG_ZEROCOPY.
>

One of the effect is that for very large queues (more than 100 MB), queue purge
might take a lot of time, in BH context (while handling one RST)

But even before the patch, this could also happen from BH context anyway.

We might use work queue (s) in the future to handle the purge in the
background in process context.
But really this is not urgent.

> Applied and queued up for -stable, thanks!

Thanks David.