From: Eric Dumazet <edumazet@google.com>
To: chia-yu.chang@nokia-bell-labs.com
Cc: pabeni@redhat.com, linux-doc@vger.kernel.org, corbet@lwn.net,
horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com,
bpf@vger.kernel.org, netdev@vger.kernel.org,
dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org,
stephen@networkplumber.org, xiyou.wangcong@gmail.com,
jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch,
donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
ij@kernel.org, ncardwell@google.com,
koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com,
ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com,
cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Subject: Re: [PATCH v15 net-next 08/14] tcp: accecn: AccECN needs to know delivered bytes
Date: Thu, 21 Aug 2025 05:24:15 -0700 [thread overview]
Message-ID: <CANn89iKvwM4EFwzuLXOr8OzddQto_rPfdBHUMLzS=xxG3USzTg@mail.gmail.com> (raw)
In-Reply-To: <20250815083930.10547-9-chia-yu.chang@nokia-bell-labs.com>
On Fri, Aug 15, 2025 at 1:39 AM <chia-yu.chang@nokia-bell-labs.com> wrote:
>
> From: Ilpo Järvinen <ij@kernel.org>
>
> AccECN byte counter estimation requires delivered bytes
> which can be calculated while processing SACK blocks and
> cumulative ACK. The delivered bytes will be used to estimate
> the byte counters between AccECN option (on ACKs w/o the
> option).
>
> Non-SACK calculation is quite annoying, inaccurate, and
> likely bogus.
Does it mean AccECN depends on SACK ?
>
> Signed-off-by: Ilpo Järvinen <ij@kernel.org>
> Signed-off-by: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2025-08-21 12:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 8:39 [PATCH v15 net-next 00/14] AccECN protocol patch series chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 01/14] tcp: reorganize SYN ECN code chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 02/14] tcp: fast path functions later chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 03/14] tcp: reorganize tcp_sock_write_txrx group for variables later chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 04/14] tcp: ecn functions in separated include file chia-yu.chang
2025-08-21 8:53 ` Eric Dumazet
2025-08-15 8:39 ` [PATCH v15 net-next 05/14] tcp: AccECN core chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 06/14] tcp: accecn: AccECN negotiation chia-yu.chang
2025-08-21 12:22 ` Eric Dumazet
2025-08-15 8:39 ` [PATCH v15 net-next 07/14] tcp: accecn: add AccECN rx byte counters chia-yu.chang
2025-08-21 8:57 ` Eric Dumazet
2025-08-15 8:39 ` [PATCH v15 net-next 08/14] tcp: accecn: AccECN needs to know delivered bytes chia-yu.chang
2025-08-21 12:24 ` Eric Dumazet [this message]
2025-08-21 14:33 ` Chia-Yu Chang (Nokia)
2025-08-15 8:39 ` [PATCH v15 net-next 09/14] tcp: sack option handling improvements chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 10/14] tcp: accecn: AccECN option chia-yu.chang
2025-08-21 12:29 ` Eric Dumazet
2025-08-21 14:58 ` Chia-Yu Chang (Nokia)
2025-08-21 17:32 ` Ilpo Järvinen
2025-08-21 17:46 ` Eric Dumazet
2025-09-02 12:23 ` Chia-Yu Chang (Nokia)
2025-08-15 8:39 ` [PATCH v15 net-next 11/14] tcp: accecn: AccECN option send control chia-yu.chang
2025-08-21 12:46 ` Eric Dumazet
2025-08-15 8:39 ` [PATCH v15 net-next 12/14] tcp: accecn: AccECN option failure handling chia-yu.chang
2025-08-21 12:55 ` Eric Dumazet
2025-08-22 10:00 ` Chia-Yu Chang (Nokia)
2025-08-15 8:39 ` [PATCH v15 net-next 13/14] tcp: accecn: AccECN option ceb/cep and ACE field multi-wrap heuristics chia-yu.chang
2025-08-15 8:39 ` [PATCH v15 net-next 14/14] tcp: accecn: try to fit AccECN option with SACK chia-yu.chang
2025-08-21 13:04 ` Eric Dumazet
2025-08-22 10:08 ` Chia-Yu Chang (Nokia)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iKvwM4EFwzuLXOr8OzddQto_rPfdBHUMLzS=xxG3USzTg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).