From: Eric Dumazet <edumazet@google.com>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
aleksander.lobakin@intel.com, lixiaoyan@google.com,
lucien.xin@gmail.com, alexanderduyck@fb.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] gro: decrease size of CB
Date: Tue, 6 Jun 2023 09:25:27 +0200 [thread overview]
Message-ID: <CANn89iLA0Wo4nHKHWatGKAoRXktG64HWbkDACuoFGYw3KHPhew@mail.gmail.com> (raw)
In-Reply-To: <20230601161407.GA9253@debian>
On Thu, Jun 1, 2023 at 6:14 PM Richard Gobert <richardbgobert@gmail.com> wrote:
>
> The GRO control block (NAPI_GRO_CB) is currently at its maximum size.
> This commit reduces its size by putting two groups of fields that are
> used only at different times into a union.
>
> Specifically, the fields frag0 and frag0_len are the fields that make up
> the frag0 optimisation mechanism, which is used during the initial
> parsing of the SKB.
>
> The fields last and age are used after the initial parsing, while the
> SKB is stored in the GRO list, waiting for other packets to arrive.
>
> There was one location in dev_gro_receive that modified the frag0 fields
> after setting last and age. I changed this accordingly without altering
> the code behaviour.
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2023-06-06 7:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:09 [PATCH v3 0/1] gro: decrease size of CB Richard Gobert
2023-06-01 16:14 ` [PATCH v3 1/1] " Richard Gobert
2023-06-06 7:25 ` Eric Dumazet [this message]
2023-06-26 8:55 ` Gal Pressman
2023-06-27 14:21 ` David Ahern
[not found] ` <b3908ce2-43e1-b56d-5d1d-48a932a2a016@nvidia.com>
2023-06-28 14:19 ` David Ahern
2023-08-23 14:43 ` Gal Pressman
2023-08-24 3:31 ` David Ahern
2023-06-29 12:36 ` Richard Gobert
[not found] ` <431d8445-9593-73df-d431-d5e76c9085cf@nvidia.com>
2023-06-30 15:39 ` Richard Gobert
2023-07-02 14:41 ` Gal Pressman
2023-07-02 14:46 ` Gal Pressman
2023-07-03 14:23 ` Richard Gobert
2023-07-07 12:31 ` Richard Gobert
2023-07-09 6:55 ` Gal Pressman
2023-06-02 14:22 ` [PATCH v3 0/1] " Alexander Lobakin
2023-06-05 13:58 ` Richard Gobert
2023-06-06 13:24 ` Alexander Lobakin
2023-06-06 9:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLA0Wo4nHKHWatGKAoRXktG64HWbkDACuoFGYw3KHPhew@mail.gmail.com \
--to=edumazet@google.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).