From: Eric Dumazet <edumazet@google.com>
To: songliubraving@fb.com
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
michael.chan@broadcom.com, Ariel Elior <ariel.elior@cavium.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
jakub.kicinski@netronome.com, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers
Date: Mon, 24 Sep 2018 12:41:20 -0700 [thread overview]
Message-ID: <CANn89iLdMaW6rcK3+JT3J56M3xT2pgPPEpQRhngBL4DocMNChw@mail.gmail.com> (raw)
In-Reply-To: <B352B219-D053-432C-AEB7-C0A74D2F6613@fb.com>
On Mon, Sep 24, 2018 at 12:31 PM Song Liu <songliubraving@fb.com> wrote:
> This triggers dev_watchdog() on a simple netperf TCP_RR on bnxt (I haven't
> tested other drivers yet).
>
> I guess this is because NAPI_STATE_SCHED is set when poll_one_napi() calls
> napi->poll(). And then cleared by napi->poll().
Which part of napi->poll() could possibly clear NAPI_STATE_SCHED when
called by netpoll ?
AFAIK, napi_complete_done() should exit early (before having a chance
to clear NAPI_STATE_SCHED)
because of :
if (unlikely(n->state & (NAPIF_STATE_NPSVC | NAPIF_STATE_IN_BUSY_POLL)))
return false;
Thanks !
next prev parent reply other threads:[~2018-09-25 1:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 22:27 [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers Eric Dumazet
2018-09-21 22:27 ` [PATCH net 01/15] netpoll: make ndo_poll_controller() optional Eric Dumazet
2018-09-21 22:27 ` [PATCH net 02/15] bonding: use netpoll_poll_dev() helper Eric Dumazet
2018-09-22 10:23 ` Jay Vosburgh
2018-09-21 22:27 ` [PATCH net 03/15] ixgbe: remove ndo_poll_controller Eric Dumazet
2018-09-21 22:27 ` [PATCH net 04/15] ixgbevf: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 05/15] fm10k: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 06/15] ixgb: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 07/15] igb: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 08/15] ice: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 09/15] i40evf: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 10/15] mlx4: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 11/15] mlx5: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 12/15] bnx2x: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 13/15] bnxt: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 14/15] nfp: " Eric Dumazet
2018-09-21 23:41 ` Jakub Kicinski
2018-09-21 22:27 ` [PATCH net 15/15] tun: " Eric Dumazet
2018-09-23 19:29 ` [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers David Miller
2018-09-23 19:47 ` Eric Dumazet
2018-09-24 5:04 ` David Miller
2018-09-24 15:30 ` Eric Dumazet
2018-09-24 19:30 ` Song Liu
2018-09-24 19:41 ` Eric Dumazet [this message]
2018-09-24 20:00 ` Song Liu
2018-09-24 20:56 ` Eric Dumazet
2018-09-24 21:05 ` Eric Dumazet
2018-09-24 21:18 ` Song Liu
2018-09-25 14:02 ` Michael Chan
2018-09-25 14:20 ` Eric Dumazet
2018-09-25 14:43 ` Michael Chan
2018-09-25 18:25 ` Song Liu
2018-09-25 21:09 ` Michael Chan
2018-09-25 23:36 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLdMaW6rcK3+JT3J56M3xT2pgPPEpQRhngBL4DocMNChw@mail.gmail.com \
--to=edumazet@google.com \
--cc=andy@greyhouse.net \
--cc=ariel.elior@cavium.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=songliubraving@fb.com \
--cc=tariqt@mellanox.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).