From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into
 sock hash
Date: Thu, 31 May 2018 21:00:23 -0400
Message-ID: <CANn89iLocj4Gth3R0+a4ppRhYHV=buWSgfEYLg+zJay25D477g@mail.gmail.com>
References: <20180530212928.190650-1-tracywwnj@gmail.com> <c6aae1fa-3ad1-9192-3e99-e177b1098f06@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Wei Wang <weiwan@google.com>, netdev <netdev@vger.kernel.org>,
        Willem de Bruijn <willemb@google.com>
To: John Fastabend <john.fastabend@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f194.google.com ([209.85.223.194]:37949 "EHLO
        mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750756AbeFABAh (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 31 May 2018 21:00:37 -0400
Received: by mail-io0-f194.google.com with SMTP id l19-v6so18121853ioj.5
        for <netdev@vger.kernel.org>; Thu, 31 May 2018 18:00:37 -0700 (PDT)
In-Reply-To: <c6aae1fa-3ad1-9192-3e99-e177b1098f06@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 31, 2018 at 7:32 PM John Fastabend <john.fastabend@gmail.com> wrote:
>
>
> Hi Wei,
>
> Thanks for the report and fix. It would be better to fix the
> root cause so that IPv6 works as intended.
>
> I'm testing the following now,
>
> Author: John Fastabend <john.fastabend@gmail.com>
> Date:   Thu May 31 14:38:59 2018 -0700
>
>     sockmap: fix crash when ipv6 sock is added by adding support for IPv6
>
>     Apparently we had a testing escape and missed IPv6. This fixes a crash
>     where we assign tcp_prot to IPv6 sockets instead of tcpv6_prot.
>
>     Signed-off-by: John Fastabend <john.fastabend@gmail.com>
>

Hi John

In any case, please forward correct attribution for Wei's work, and
syzbot 'Reported-by'

Are you sure you are handling IPv4 mapped in IPv6 sockets as well ?

Thanks.