From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver
Date: Tue, 16 Nov 2021 22:47:22 +0100 [thread overview]
Message-ID: <CANr-f5yiJG_+K63NpSuiAefqM4Cb=UWEdBGKv6mkS5fMZ96new@mail.gmail.com> (raw)
In-Reply-To: <577ffb42-d74e-9da7-d921-b7f62c26b596@gmail.com>
On Mon, Nov 15, 2021 at 11:21 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> On 15.11.2021 21:50, Gerhard Engleder wrote:
> > + /* entry->properties shall be valid before write pointer is
> > + * incrememted
> > + */
> > + wmb();
>
> A lighter variant like smp_wmb() is not sufficient here?
This is some leftover from lockless descriptor ring processing, which has
been replaced by a spinlock. I will remove it.
> > + dma_rmb();
> > +
>
> Memory barriers should always have a comment explaining why
> they are needed. I think checkpatch would complain here.
I don't see any checkpatch warning, but you are right. I will document
all DMA memory barriers.
Gerhard
next prev parent reply other threads:[~2021-11-16 21:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 20:50 [PATCH net-next v5 0/3] TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-11-15 20:50 ` [PATCH net-next v5 1/3] dt-bindings: Add vendor prefix for Engleder Gerhard Engleder
2021-11-15 22:24 ` Andrew Lunn
2021-11-15 20:50 ` [PATCH net-next v5 2/3] dt-bindings: net: Add tsnep Ethernet controller Gerhard Engleder
2021-11-15 22:25 ` Andrew Lunn
2021-11-15 20:50 ` [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-11-15 22:21 ` Heiner Kallweit
2021-11-16 21:47 ` Gerhard Engleder [this message]
2021-11-15 23:04 ` Andrew Lunn
2021-11-16 22:16 ` Gerhard Engleder
2021-11-16 23:41 ` Andrew Lunn
2021-11-18 17:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANr-f5yiJG_+K63NpSuiAefqM4Cb=UWEdBGKv6mkS5fMZ96new@mail.gmail.com' \
--to=gerhard@engleder-embedded.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).