[PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

[PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

[Alok Tiwari]

The warning in bnxt_alloc_one_rx_ring_netmem() reports the number
of pages allocated for the RX aggregation ring. However, it
mistakenly used bp->rx_ring_size instead of bp->rx_agg_ring_size,
leading to confusing or misleading log output.

Use the correct bp->rx_agg_ring_size value to fix this.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 207a8bb36ae5..0d30abadf06c 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4397,7 +4397,7 @@ static void bnxt_alloc_one_rx_ring_netmem(struct bnxt *bp,
 	for (i = 0; i < bp->rx_agg_ring_size; i++) {
 		if (bnxt_alloc_rx_netmem(bp, rxr, prod, GFP_KERNEL)) {
 			netdev_warn(bp->dev, "init'ed rx ring %d with %d/%d pages only\n",
-				    ring_nr, i, bp->rx_ring_size);
+				    ring_nr, i, bp->rx_agg_ring_size);
 			break;
 		}
 		prod = NEXT_RX_AGG(prod);
-- 
2.50.1

Re: [PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

[Jacob Keller]

[-- Attachment #1.1: Type: text/plain, Size: 1256 bytes --]



On 8/28/2025 12:48 PM, Alok Tiwari wrote:
> The warning in bnxt_alloc_one_rx_ring_netmem() reports the number
> of pages allocated for the RX aggregation ring. However, it
> mistakenly used bp->rx_ring_size instead of bp->rx_agg_ring_size,
> leading to confusing or misleading log output.
> 
> Use the correct bp->rx_agg_ring_size value to fix this.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 207a8bb36ae5..0d30abadf06c 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -4397,7 +4397,7 @@ static void bnxt_alloc_one_rx_ring_netmem(struct bnxt *bp,
>  	for (i = 0; i < bp->rx_agg_ring_size; i++) {
>  		if (bnxt_alloc_rx_netmem(bp, rxr, prod, GFP_KERNEL)) {
>  			netdev_warn(bp->dev, "init'ed rx ring %d with %d/%d pages only\n",
> -				    ring_nr, i, bp->rx_ring_size);
> +				    ring_nr, i, bp->rx_agg_ring_size);
>  			break;
>  		}
>  		prod = NEXT_RX_AGG(prod);


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: [PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

On Thu, Aug 28, 2025 at 12:49 PM Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
>
> The warning in bnxt_alloc_one_rx_ring_netmem() reports the number
> of pages allocated for the RX aggregation ring. However, it
> mistakenly used bp->rx_ring_size instead of bp->rx_agg_ring_size,
> leading to confusing or misleading log output.
>
> Use the correct bp->rx_agg_ring_size value to fix this.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Please add the Fixes tag since this is a bug fix.  Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4196 bytes --]

Re: [PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

[Somnath Kotur]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Fri, Aug 29, 2025 at 6:01 AM Michael Chan <michael.chan@broadcom.com> wrote:
>
> On Thu, Aug 28, 2025 at 12:49 PM Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
> >
> > The warning in bnxt_alloc_one_rx_ring_netmem() reports the number
> > of pages allocated for the RX aggregation ring. However, it
> > mistakenly used bp->rx_ring_size instead of bp->rx_agg_ring_size,
> > leading to confusing or misleading log output.
> >
> > Use the correct bp->rx_agg_ring_size value to fix this.
> >
> > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Please add the Fixes tag since this is a bug fix.  Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4199 bytes --]