netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aring@mojatatu.com>
To: David Miller <davem@davemloft.net>
Cc: "Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Cong Wang" <xiyou.wangcong@gmail.com>,
	"Jiří Pírko" <jiri@resnulli.us>,
	netdev@vger.kernel.org, kernel@mojatatu.com,
	"David Ahern" <dsahern@gmail.com>
Subject: Re: [PATCH net-next 0/6] net: sched: sch: introduce extack support
Date: Wed, 6 Dec 2017 17:34:08 -0500	[thread overview]
Message-ID: <CAOHTAphUCUnY03yaZJCAXG2eODFP3EFfGo+FUMV9cjcmmzABqw@mail.gmail.com> (raw)
In-Reply-To: <20171206.154009.1362727654214640336.davem@davemloft.net>

Hi,

On Wed, Dec 6, 2017 at 3:40 PM, David Miller <davem@davemloft.net> wrote:
> From: Alexander Aring <aring@mojatatu.com>
> Date: Wed,  6 Dec 2017 11:08:39 -0500
>
>> this patch series basically add support for extack in common qdisc handling.
>> Additional it adds extack pointer to common qdisc callback handling this
>> offers per qdisc implementation to setting the extack message for each
>> failure over netlink.
>>
>> The extack message will be set deeper in qdisc functions but going not
>> deeper as net core api. For qdisc module callback handling, the extack
>> will not be set. This will be part of per qdisc extack handling.
>>
>> I also want to prepare patches to handle extack per qdisc module...
>> so there will come a lot of more patches, just cut them down to make
>> it reviewable.
>>
>> There are some above 80-chars width warnings, which I ignore because
>> it looks more ugly otherwise.
>>
>> This patch-series based on patches by David Ahren which gave me some
>> hints how to deal with extack support.
>>
>> Cc: David Ahern <dsahern@gmail.com>
>
> Only add the plumbing when you have actual extack messages you are
> adding as an example use case.
>

I did not understand. I have a lot of patches which make use of these
changes. Do you want me to submit me these in one shot (patch-series)?
I was hoping to making it in smaller patch-series for easier review.

- Alex

  reply	other threads:[~2017-12-06 22:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 16:08 [PATCH net-next 0/6] net: sched: sch: introduce extack support Alexander Aring
2017-12-06 16:08 ` [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors Alexander Aring
2017-12-06 16:52   ` Jamal Hadi Salim
2017-12-07  5:28   ` David Ahern
2017-12-07 12:04     ` Jamal Hadi Salim
2017-12-07 17:52       ` David Ahern
2017-12-07 18:08         ` David Miller
2017-12-06 16:08 ` [PATCH net-next 2/6] net: sched: sch: add extack for init callback Alexander Aring
2017-12-06 16:54   ` Jamal Hadi Salim
2017-12-06 16:08 ` [PATCH net-next 3/6] net: sched: sch: add extack for change qdisc ops Alexander Aring
2017-12-06 16:56   ` Jamal Hadi Salim
2017-12-06 16:08 ` [PATCH net-next 4/6] net: sched: sch: add extack to change class Alexander Aring
2017-12-06 16:56   ` Jamal Hadi Salim
2017-12-06 16:08 ` [PATCH net-next 5/6] net: sched: sch: add extack for block callback Alexander Aring
2017-12-06 16:57   ` Jamal Hadi Salim
2017-12-06 16:08 ` [PATCH net-next 6/6] net: sched: sch: add extack for graft callback Alexander Aring
2017-12-06 16:58   ` Jamal Hadi Salim
2017-12-06 19:10 ` [PATCH net-next 0/6] net: sched: sch: introduce extack support Cong Wang
2017-12-06 20:40 ` David Miller
2017-12-06 22:34   ` Alexander Aring [this message]
2017-12-06 22:36     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOHTAphUCUnY03yaZJCAXG2eODFP3EFfGo+FUMV9cjcmmzABqw@mail.gmail.com \
    --to=aring@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).