From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: Re: [PATCH net-next 0/6] net: sched: sch: introduce extack support Date: Wed, 6 Dec 2017 17:34:08 -0500 Message-ID: References: <20171206160845.6646-1-aring@mojatatu.com> <20171206.154009.1362727654214640336.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Jamal Hadi Salim , Cong Wang , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , netdev@vger.kernel.org, kernel@mojatatu.com, David Ahern To: David Miller Return-path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:43497 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbdLFWeP (ORCPT ); Wed, 6 Dec 2017 17:34:15 -0500 Received: by mail-ua0-f193.google.com with SMTP id e10so3986441uah.10 for ; Wed, 06 Dec 2017 14:34:15 -0800 (PST) In-Reply-To: <20171206.154009.1362727654214640336.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi, On Wed, Dec 6, 2017 at 3:40 PM, David Miller wrote: > From: Alexander Aring > Date: Wed, 6 Dec 2017 11:08:39 -0500 > >> this patch series basically add support for extack in common qdisc handling. >> Additional it adds extack pointer to common qdisc callback handling this >> offers per qdisc implementation to setting the extack message for each >> failure over netlink. >> >> The extack message will be set deeper in qdisc functions but going not >> deeper as net core api. For qdisc module callback handling, the extack >> will not be set. This will be part of per qdisc extack handling. >> >> I also want to prepare patches to handle extack per qdisc module... >> so there will come a lot of more patches, just cut them down to make >> it reviewable. >> >> There are some above 80-chars width warnings, which I ignore because >> it looks more ugly otherwise. >> >> This patch-series based on patches by David Ahren which gave me some >> hints how to deal with extack support. >> >> Cc: David Ahern > > Only add the plumbing when you have actual extack messages you are > adding as an example use case. > I did not understand. I have a lot of patches which make use of these changes. Do you want me to submit me these in one shot (patch-series)? I was hoping to making it in smaller patch-series for easier review. - Alex