From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Kirjanov Subject: Re: [PATCH] mips: bpf: Fix broken BPF_MOD Date: Mon, 1 Dec 2014 17:55:38 +0400 Message-ID: References: <1417427822-12729-1-git-send-email-kda@linux-powerpc.org> <547C7240.4010401@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: netdev@vger.kernel.org, markos.chandras@imgtec.com To: Sergei Shtylyov Return-path: Received: from mail-yh0-f51.google.com ([209.85.213.51]:61531 "EHLO mail-yh0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbaLANzj (ORCPT ); Mon, 1 Dec 2014 08:55:39 -0500 Received: by mail-yh0-f51.google.com with SMTP id a41so4874943yho.10 for ; Mon, 01 Dec 2014 05:55:39 -0800 (PST) In-Reply-To: <547C7240.4010401@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: On 12/1/14, Sergei Shtylyov wrote: > Hello. > > On 12/1/2014 12:57 PM, Denis Kirjanov wrote: > > You should CC the 'linux-mips' ML. > >> Remove optimize_div() from BPF_MOD | BPF_K case >> since we don't know the dividend and fix the >> emit_mod() by reading the mod operation result from HI register > > Isn't this 2 unrelated fixes? They should be in 2 patches, not a single > > one in that case. > They do fix the BPD_MOD _single_ case. I don't think that it's a good reason here to split the fin in 2 patches >> Signed-off-by: Denis Kirjanov >> --- >> arch/mips/net/bpf_jit.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > WBR, Sergei > >