From: Fabio Estevam <festevam@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
l00g33k@gmail.com
Cc: netdev <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
sashal@kernel.org
Subject: mv88e6xxx: Timeout waiting for EEPROM done
Date: Thu, 14 Sep 2023 11:31:37 -0300 [thread overview]
Message-ID: <CAOMZO5AE3HkjRb9-UsoG44XL064Lca7zx9gG47+==GbhVPUFsw@mail.gmail.com> (raw)
Hi,
On an imx8mn-based board with an 88E6320 switch, the following error
started showing up after the commit below on the 6.1 LTS branch:
mv88e6085 30be0000.ethernet-1:00: Timeout waiting for EEPROM done
commit df83af3b996d79d7eb51eaefdffb7f4352e55052
Author: Alfred Lee <l00g33k@gmail.com>
Date: Mon Aug 14 17:13:23 2023 -0700
net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset
[ Upstream commit 23d775f12dcd23d052a4927195f15e970e27ab26 ]
If the switch is reset during active EEPROM transactions, as in
just after an SoC reset after power up, the I2C bus transaction
may be cut short leaving the EEPROM internal I2C state machine
in the wrong state. When the switch is reset again, the bad
state machine state may result in data being read from the wrong
memory location causing the switch to enter unexpected mode
rendering it inoperational.
Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done
after HW reset")
Signed-off-by: Alfred Lee <l00g33k@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230815001323.24739-1-l00g33k@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
What is the proper way to avoid this error?
Thanks
next reply other threads:[~2023-09-14 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 14:31 Fabio Estevam [this message]
2023-09-14 15:15 ` mv88e6xxx: Timeout waiting for EEPROM done Andrew Lunn
2023-09-14 16:22 ` Fabio Estevam
2023-09-14 19:05 ` Fabio Estevam
2023-09-14 21:38 ` Andrew Lunn
2023-09-15 0:40 ` Fabio Estevam
2023-09-15 13:08 ` Andrew Lunn
2023-09-15 14:13 ` Fabio Estevam
2023-09-15 14:34 ` Andrew Lunn
2023-09-15 17:05 ` Fabio Estevam
2023-09-15 18:23 ` Andrew Lunn
2023-09-19 19:23 ` Fabio Estevam
2023-09-19 19:44 ` Andrew Lunn
2023-09-20 0:47 ` Fabio Estevam
2023-09-20 14:52 ` Andrew Lunn
2023-09-20 16:28 ` Fabio Estevam
2023-09-20 16:46 ` Andrew Lunn
2023-09-16 21:43 ` Alfred Lee
2023-09-19 18:14 ` Alfred Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5AE3HkjRb9-UsoG44XL064Lca7zx9gG47+==GbhVPUFsw@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=l00g33k@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).