From: Fabio Estevam <festevam@gmail.com>
To: Greg Ungerer <gerg@uclinux.org>
Cc: Troy Kisky <troy.kisky@boundarydevices.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages
Date: Wed, 30 Mar 2016 15:37:15 -0300 [thread overview]
Message-ID: <CAOMZO5B79aHocuqT4jgEU9gGcFYD5ZSDZh8PrGeXYAcLHW1x5Q@mail.gmail.com> (raw)
In-Reply-To: <56FB46EA.7050401@uclinux.org>
Hi Greg,
On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer <gerg@uclinux.org> wrote:
> Hi Troy,
>
> Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error
> messages') adds a write to a register that is not present in all
> implementations of the FEC hardware module. None of the ColdFire
> SoC parts with the FEC module have the FTRL (0x1b0) register.
>
> Does this need a quirk flag to key access to this register of?
> Or can you piggyback on the FEC_QUIRK_HAS_RACC flag?
Would the change below work on Coldfire?
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev)
else
val &= ~FEC_RACC_OPTIONS;
writel(val, fep->hwp + FEC_RACC);
- }
writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
+ }
#endif
/*
next prev parent reply other threads:[~2016-03-30 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 3:24 [PATCH] net: fec: stop the "rcv is not +last, " error messages Greg Ungerer
2016-03-30 17:04 ` Troy Kisky
2016-03-30 18:37 ` Fabio Estevam [this message]
2016-03-31 1:17 ` Greg Ungerer
2016-03-31 10:58 ` Fabio Estevam
2016-03-31 1:41 ` Fugang Duan
2016-03-31 1:59 ` Greg Ungerer
2016-03-31 10:56 ` Fabio Estevam
2016-04-01 1:37 ` Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5B79aHocuqT4jgEU9gGcFYD5ZSDZh8PrGeXYAcLHW1x5Q@mail.gmail.com \
--to=festevam@gmail.com \
--cc=gerg@uclinux.org \
--cc=netdev@vger.kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).